-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improve 'zpool labelclear' command #8548
Conversation
That patch follows: openzfs#8500 and is a port to ZoL of: openzfs/openzfs#424 It adds the following: - ability to clear a specific label (options -b, -e and -i) - label invalidation using a single-byte modification (wipe with option -w) - option -ff to force invalidation even for invalid labels OpenZFS-issue: https://www.illumos.org/issues/7584
I haven't often had need for |
Hello Matthew, Thanks for the update. The original idea was :
If you think this is not worth updating that patch, feel free to close that PR. Best regards, Ganael. |
Hello @tonyhutter, Thanks ! Our patches do not act on the same things : your patch focuses on allowing clearing valid labels from active pools while mine allows clearing invalid labels (see: 7c62008#diff-8f1a174ac28c3b0269336b69d4cbd5d057fb6e65b62321f54c4dce5c8ab2d14bR1168 and 7c62008#diff-4d1ee8409af09d86d05eb396741ef7c3a1ba2cad77a58777164c4866084fb140R177). They can be seen as complementary if we really want to avoid using dd to clear labels. Cheers, Ganael. |
I think that we would need to find a specific use case for this, otherwise we'll close this PR. |
Hello Matthew, As there has been no interest shown in the features brought by the patch, I presume we can close that PR. Best regards, Ganael. |
Thanks Ganael, if you have other ideas for how to improve OpenZFS please let us know by opening a PR or discussing them at our monthly meeting. |
Hello,
That patch follows : #8500 to further improve the labelclear command.
It is an updated version of my my previous patch for OpenZFS :
openzfs/openzfs#424
Description
Basically, the patch adds the following :
How Has This Been Tested?
The patch has been tested on Debian 9 with a file-backed zpool.
Types of changes
Checklist:
Signed-off-by
.