zdb long options #8846
zdb long options #8846
Conversation
…n page. Signed-off-by: Richard Elling <Richard.Elling@RichardElling.com>
Codecov Report
@@ Coverage Diff @@
## master #8846 +/- ##
==========================================
- Coverage 78.77% 78.65% -0.12%
==========================================
Files 382 382
Lines 117770 117754 -16
==========================================
- Hits 92775 92625 -150
- Misses 24995 25129 +134
Continue to review full report at Codecov.
|
| "\t\t<poolname> <vdev>:<offset>:<size>[:<flags>]\n" | ||
| "\t%s -E [-A] word0:word1:...:word15\n" | ||
| "\t%s -S [-AP] [-e [-V] [-p <path> ...]] [-U <cache>] " | ||
| "\t%s -S [-AP] [-e [-V] [-p <path> ...]] [-U <cachefile>] " |
There was a problem hiding this comment.
It doesn't look like this help output is yet over the 80 column limit. But this would be a good opportunity to extend commit 2696e86 to cover the zdb help output.
There was a problem hiding this comment.
good idea, I'll add a test case for this
| "Options to control amount of output:\n" | ||
| " -b, --block block information\n" | ||
| " -c, --checksum checksum all metadata " | ||
| "(-cc for all data) blocks\n" |
There was a problem hiding this comment.
It looks like there are some tabs vs spaces white space formatting issues for this block.
| @@ -6042,12 +6118,27 @@ main(int argc, char **argv) | |||
| argc -= optind; | |||
| argv += optind; | |||
|
|
|||
| if (argc < 2 && dump_opt['R']) | |||
| if (getenv("ZFS_OPTIONS_DEBUG") != NULL) { | |||
There was a problem hiding this comment.
Can you either document ZFS_OPTIONS_DEBUG in the zdb man page, or if it's intended to only be used for internal ZTS testing add a comment to that effect here.
There was a problem hiding this comment.
it is for testing only, I'll add references to make it clearer
behlendorf
added
Status: Revision Needed
behlendorf
added
Status: Work in Progress
|
@richardelling how would you like to move forward with this. If you could address the handful of review comments and get it rebased we can get it merged. |
|
I've got too many deadlines this week, was planning to rebase and address the other comments this weekend. |
|
@richardelling it'd be great if you could dust this off, rebase, and address the comments. |
ahrens
added
Status: Inactive
|
@richardelling When do you think you'll have time to get back to this? |
|
after supercomputing conference |
|
Closing. @richardelling if you get a chance to get back to this please feel free to open a new PR. |
Add long options to zdb command.
Includes updates to ZTS tests and man page.
Includes fix for known failures of
zdb_006_posMotivation and Context
Resolves #8739
Description
Adds long option names for existing zdb options.
Adds
--helpIncludes support for future long options that will be needed for the
draid project.
How Has This Been Tested?
ZTS tests included and pass
Types of changes
Checklist:
Signed-off-by.