Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unencrypted children of encrypted datasets #8870

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Allow unencrypted children of encrypted datasets #8870

merged 1 commit into from
Jun 20, 2019

Conversation

tcaputi
Copy link
Contributor

@tcaputi tcaputi commented Jun 7, 2019

When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Fixes: #8737

Signed-off-by: Tom Caputi tcaputi@datto.com

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jun 7, 2019
@behlendorf behlendorf added Status: Design Review Needed Architecture or design is under discussion and removed Status: Code Review Needed Ready for review and testing labels Jun 13, 2019
@behlendorf
Copy link
Contributor

@kithrup @jasonbking @rlaager would you mind reviewing this change.

kithrup
kithrup approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@kithrup kithrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one question about verb tense (which isn't a code issue, just a grammar question), this looks good to me. It's mostly removing code that isn't used with the new philosophy.

@jasonbking
Copy link
Contributor

Other than the wording @kithrup noted, LGTM.

rlaager
rlaager approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrens
Copy link
Member

ahrens commented Jun 16, 2019

I didn't look at the code in detail, but the idea is fine with me.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Design Review Needed Architecture or design is under discussion labels Jun 19, 2019
Allow unencrypted children of encrypted datasets
231ac3f 
When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Fixes: openzfs#8737

Signed-off-by: Tom Caputi <tcaputi@datto.com>
@codecov
Copy link

codecov bot commented Jun 20, 2019 •
edited
Loading

Codecov Report

Merging #8870 into master will increase coverage by 12.47%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8870       +/-   ##
===========================================
+ Coverage   66.26%   78.73%   +12.47%     
===========================================
  Files         324      382       +58     
  Lines      103014   117727    +14713     
===========================================
+ Hits        68261    92693    +24432     
+ Misses      34753    25034     -9719
Flag Coverage Δ
#kernel 79.27% <38.46%> (?)
#user 67.36% <35%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0be12...231ac3f. Read the comment docs.

@behlendorf behlendorf merged commit da68988 into openzfs:master Jun 20, 2019
@FiloSottile FiloSottile mentioned this pull request Aug 2, 2019
Closed
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@tonyhutter
Allow unencrypted children of encrypted datasets
250a8bb 
When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Reviewed-by: Jason King <jason.king@joyent.com>
Reviewed-by: Sean Eric Fagan <sef@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8737
Closes openzfs#8870
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@tonyhutter
Allow unencrypted children of encrypted datasets
5039d10 
When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Reviewed-by: Jason King <jason.king@joyent.com>
Reviewed-by: Sean Eric Fagan <sef@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8737
Closes openzfs#8870
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@tonyhutter
Allow unencrypted children of encrypted datasets
ebbd048 
When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Reviewed-by: Jason King <jason.king@joyent.com>
Reviewed-by: Sean Eric Fagan <sef@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8737
Closes openzfs#8870
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@tonyhutter
Allow unencrypted children of encrypted datasets
8225358 
When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Reviewed-by: Jason King <jason.king@joyent.com>
Reviewed-by: Sean Eric Fagan <sef@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8737
Closes openzfs#8870
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@tonyhutter
Allow unencrypted children of encrypted datasets
f716e0e 
When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Reviewed-by: Jason King <jason.king@joyent.com>
Reviewed-by: Sean Eric Fagan <sef@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#8737
Closes openzfs#8870
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@tonyhutter
Allow unencrypted children of encrypted datasets
b96ceee 
When encryption was first added to ZFS, we made a decision to
prevent users from creating unencrypted children of encrypted
datasets. The idea was to prevent users from inadvertently
leaving some of their data unencrypted. However, since the
release of 0.8.0, some legitimate reasons have been brought up
for this behavior to be allowed. This patch simply removes this
limitation from all code paths that had checks for it and updates
the tests accordingly.

Reviewed-by: Jason King <jason.king@joyent.com>
Reviewed-by: Sean Eric Fagan <sef@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #8737
Closes #8870
@AttilaFueloep AttilaFueloep mentioned this pull request Jan 28, 2022
Closed
@rincebrain rincebrain mentioned this pull request Nov 1, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kithrup kithrup kithrup approved these changes

@behlendorf behlendorf behlendorf approved these changes

@rlaager rlaager rlaager approved these changes

@ahrens ahrens Awaiting requested review from ahrens

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encrypted datasets cannot have unencrypted children
6 participants
@tcaputi @behlendorf @jasonbking @ahrens @rlaager @kithrup