Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python config cleanup #8895

Merged
merged 1 commit into from Jun 13, 2019
Merged

Python config cleanup #8895

merged 1 commit into from Jun 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2019 •
edited by ghost
Loading

Motivation and Context

Description

Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Simplify nested tests to flat case pattern-matching statements.
Make test syntax more consistent.

How Has This Been Tested?

I've tested the following configurations:

  • no options, with no python installed
  • no options, with python3
  • --without-python
  • --disable-pyzfs
  • --with-python=python2 --disable-pyzfs
  • --with-python=3 --disable-pyzfs with no python installed
  • --with-python=2 --disable-pyzfs with python3 installed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Python config cleanup
3d23b16 
Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Make test syntax more consistent.

Sponsored by: iXsystems, Inc.
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Type: Building Indicates an issue related to building binaries labels Jun 12, 2019
behlendorf
behlendorf approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Conan-Kudo would you mind reviewing this.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 13, 2019
@behlendorf
Copy link
Contributor

@freqlabs one question, while I don't see anything bashspecific in this change. I wanted to make sure this was manually tested using an alternative like ash, dash, etc, since we've been bitten by that before.

@ghost
Copy link
Author

ghost commented Jun 13, 2019

@behlendorf I did my testing on FreeBSD where /bin/sh is a derivative of ash.

@behlendorf behlendorf merged commit b1b4ac2 into openzfs:master Jun 13, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@tonyhutter
Python config cleanup
7aefa2c 
Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Make test syntax more consistent.

Sponsored by: iXsystems, Inc.
Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#8895
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@tonyhutter
Python config cleanup
0779380 
Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Make test syntax more consistent.

Sponsored by: iXsystems, Inc.
Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#8895
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@tonyhutter
Python config cleanup
4e6ec79 
Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Make test syntax more consistent.

Sponsored by: iXsystems, Inc.
Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#8895
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@tonyhutter
Python config cleanup
271e13d 
Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Make test syntax more consistent.

Sponsored by: iXsystems, Inc.
Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#8895
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@tonyhutter
Python config cleanup
8e84f10 
Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Make test syntax more consistent.

Sponsored by: iXsystems, Inc.
Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#8895
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@tonyhutter
Python config cleanup
9e54b9d 
Don't require Python at configure/build unless building pyzfs.
Move ZFS_AC_PYTHON_MODULE to always-pyzfs.m4 where it is used.
Make test syntax more consistent.

Sponsored by: iXsystems, Inc.
Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes #8895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @Conan-Kudo