Add libnvpair to libzfs pkg-config #8919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions such as `fnvlist_lookup_nvlist` need libnvpair to be linked. Default pkg-config file did not contain it. Signed-off-by: Harry Mallon <hjmallon@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8919 +/- ##
==========================================
+ Coverage 78.66% 78.72% +0.06%
==========================================
Files 382 382
Lines 117840 117840
==========================================
+ Hits 92698 92771 +73
+ Misses 25142 25069 -73
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Jun 19, 2019
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 13, 2019
Functions such as `fnvlist_lookup_nvlist` need libnvpair to be linked. Default pkg-config file did not contain it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Harry Mallon <hjmallon@gmail.com> Closes openzfs#8919
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 22, 2019
Functions such as `fnvlist_lookup_nvlist` need libnvpair to be linked. Default pkg-config file did not contain it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Harry Mallon <hjmallon@gmail.com> Closes openzfs#8919
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 23, 2019
Functions such as `fnvlist_lookup_nvlist` need libnvpair to be linked. Default pkg-config file did not contain it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Harry Mallon <hjmallon@gmail.com> Closes openzfs#8919
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 17, 2019
Functions such as `fnvlist_lookup_nvlist` need libnvpair to be linked. Default pkg-config file did not contain it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Harry Mallon <hjmallon@gmail.com> Closes openzfs#8919
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
Functions such as `fnvlist_lookup_nvlist` need libnvpair to be linked. Default pkg-config file did not contain it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Harry Mallon <hjmallon@gmail.com> Closes openzfs#8919
tonyhutter
pushed a commit
that referenced
this pull request
Sep 26, 2019
Functions such as `fnvlist_lookup_nvlist` need libnvpair to be linked. Default pkg-config file did not contain it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Harry Mallon <hjmallon@gmail.com> Closes #8919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions such as
fnvlist_lookup_nvlistneed libnvpair to be linked.Default pkg-config file did not contain it.
Signed-off-by: Harry Mallon hjmallon@gmail.com
Motivation and Context
Building purely using pkg-config for libzfs was failing for me.
Description
Functions such as
fnvlist_lookup_nvlistneed libnvpair to be linked.Default pkg-config file did not contain it.
How Has This Been Tested?
Ran on my local machine (CentOS 7, ZFS 0.7.12)
Types of changes
Checklist:
Signed-off-by.