Add support for FreeBSD #8987
Merged
Add support for FreeBSD #8987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
the
Status: Design Review Needed
mattmacy
force-pushed
the
projects/pr-rebase
branch
from
673caef
to
d51c99b
Compare
lundman
reviewed
Jul 3, 2019
include/sys/abd.h
Outdated
| uint_t abd_nents; | ||
| struct scatterlist *abd_sgl; | ||
| #endif | ||
| } abd_scatter; |
There was a problem hiding this comment.
I do wonder if #if linux around the scatterlist wouldn't be easier, or it'll be
#if ( defined(__FreeBSD__) || defined(__APPLE__) || defined(_WIN32)) && defined(_KERNEL)
But don't change anything, just curious what people think, is reducing #ifdefs even on the agenda just yet? I'm probably here waaay too early
There was a problem hiding this comment.
@lundman your timing is perfect! Reducing the #ifdefs is definitely on the agenda as is any additional refactoring we should be considering to make things easier when adding additional platforms.
mattmacy
force-pushed
the
projects/pr-rebase
branch
from
d51c99b
to
e0f971d
Compare
mattmacy
force-pushed
the
projects/pr-rebase
branch
6 times, most recently
from
9e6ea37
to
4df3869
Compare
kmoore134
added a commit
to truenas/ports
that referenced
this pull request
Jul 8, 2019
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 8, 2019
This brings us up to date with the code currently in review in: openzfs/zfs#8987 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@506233 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 8, 2019
This brings us up to date with the code currently in review in: openzfs/zfs#8987
mattmacy
force-pushed
the
projects/pr-rebase
branch
from
d63de7c
to
ff98df6
Compare
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Jul 8, 2019
This brings us up to date with the code currently in review in: openzfs/zfs#8987 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@506233 35697150-7ecd-e111-bb59-0022644237b5
mattmacy
force-pushed
the
projects/pr-rebase
branch
3 times, most recently
from
e6ea76b
to
137b90d
Compare
|
NB, when building packages, such as rpm, the build system looks for shebang in files to generate the package dependencies. Thus you will need to ensure the dependency on python3 in packages remains. |
mattmacy
force-pushed
the
projects/pr-rebase
branch
from
7db8ab1
to
774a635
Compare
rlaager
reviewed
Jul 12, 2019
mattmacy
force-pushed
the
projects/pr-rebase
branch
8 times, most recently
from
9b19313
to
4e4e10c
Compare
ghost
force-pushed
the
projects/pr-rebase
branch
6 times, most recently
from
a274154
to
178bcd7
Compare
ghost
force-pushed
the
projects/pr-rebase
branch
from
178bcd7
to
8bbe4fa
Compare
behlendorf
added
Status: Accepted
ghost
force-pushed
the
projects/pr-rebase
branch
2 times, most recently
from
6e0563f
to
85d3c6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #8987 +/- ##
==========================================
- Coverage 79.48% 79.30% -0.19%
==========================================
Files 387 388 +1
Lines 123388 123386 -2
==========================================
- Hits 98079 97855 -224
- Misses 25309 25531 +222
Continue to review full report at Codecov.
|
ghost
force-pushed
the
projects/pr-rebase
branch
7 times, most recently
from
93b0a2f
to
d3718e3
Compare
- Import FreeBSD specific parts Signed-off-by: Matt Macy <mmacy@FreeBSD.org> Co-authored-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Requires-builders: arch,style,coverage,amazon2,centos7,debian10,ubuntu16,ubuntu18,builtin,freebsd12,freebsd13
ghost
force-pushed
the
projects/pr-rebase
branch
from
d3718e3
to
69c630f
Compare
behlendorf
approved these changes
Apr 14, 2020
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Add the FreeBSD platform code to the OpenZFS repository. As of this commit the source can be compiled and tested on FreeBSD 11 and 12. Subsequent commits are now required to compile on FreeBSD and Linux. Additionally, they must pass the ZFS Test Suite on FreeBSD which is being run by the CI. As of this commit 1230 tests pass on FreeBSD and there are no unexpected failures. Reviewed-by: Sean Eric Fagan <sef@ixsystems.com> Reviewed-by: Jorgen Lundman <lundman@lundman.net> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Co-authored-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Matt Macy <mmacy@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#898 Closes openzfs#8987
asomers
added a commit
to asomers/zfs
that referenced
this pull request
Jun 14, 2024
This applies the same change in openzfs#9115 to FreeBSD. This was actually the old behavior in FreeBSD 12; it only regressed when FreeBSD support was added to OpenZFS. As far as I can tell, the timeline went like this: * Illumos's zfsvfs_teardown used an unconditional txg_wait_synced * Illumos added the dirty data check [^4] * FreeBSD merged in Illumos's conditional check [^3] * OpenZFS forked from Illumos * OpenZFS removed the dirty data check in openzfs#7795 [^5] * @mattmacy forked the OpenZFS repo and began to add FreeBSD support * OpenZFS PR openzfs#9115[^1] recreated the same dirty data check that Illumos used, in slightly different form. At this point the OpenZFS repo did not yet have multi-OS support. * Matt Macy merged in FreeBSD support in openzfs#8987[^2] , but it was based on slightly outdated OpenZFS code. In my local testing, this vastly improves the reboot speed of a server with a large pool that has 1000 datasets and is resilvering an HDD. [^1]: openzfs#9115 [^2]: openzfs#8987 [^3]: freebsd/freebsd-src@10b9d77 [^4]: illumos/illumos-gate@5aaeed5 [^5]: openzfs#7795 Sponsored by: Axcient Signed-off-by: Alan Somers <asomers@gmail.com>
13 tasks
behlendorf
pushed a commit
that referenced
this pull request
Aug 9, 2024
This applies the same change in #9115 to FreeBSD. This was actually the old behavior in FreeBSD 12; it only regressed when FreeBSD support was added to OpenZFS. As far as I can tell, the timeline went like this: * Illumos's zfsvfs_teardown used an unconditional txg_wait_synced * Illumos added the dirty data check [^4] * FreeBSD merged in Illumos's conditional check [^3] * OpenZFS forked from Illumos * OpenZFS removed the dirty data check in #7795 [^5] * @mattmacy forked the OpenZFS repo and began to add FreeBSD support * OpenZFS PR #9115[^1] recreated the same dirty data check that Illumos used, in slightly different form. At this point the OpenZFS repo did not yet have multi-OS support. * Matt Macy merged in FreeBSD support in #8987[^2] , but it was based on slightly outdated OpenZFS code. In my local testing, this vastly improves the reboot speed of a server with a large pool that has 1000 datasets and is resilvering an HDD. [^1]: #9115 [^2]: #8987 [^3]: freebsd/freebsd-src@10b9d77 [^4]: illumos/illumos-gate@5aaeed5 [^5]: #7795 Sponsored by: Axcient Reviewed-by: Allan Jude <allan@klarasystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes #16268
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
This applies the same change in openzfs#9115 to FreeBSD. This was actually the old behavior in FreeBSD 12; it only regressed when FreeBSD support was added to OpenZFS. As far as I can tell, the timeline went like this: * Illumos's zfsvfs_teardown used an unconditional txg_wait_synced * Illumos added the dirty data check [^4] * FreeBSD merged in Illumos's conditional check [^3] * OpenZFS forked from Illumos * OpenZFS removed the dirty data check in openzfs#7795 [^5] * @mattmacy forked the OpenZFS repo and began to add FreeBSD support * OpenZFS PR openzfs#9115[^1] recreated the same dirty data check that Illumos used, in slightly different form. At this point the OpenZFS repo did not yet have multi-OS support. * Matt Macy merged in FreeBSD support in openzfs#8987[^2] , but it was based on slightly outdated OpenZFS code. In my local testing, this vastly improves the reboot speed of a server with a large pool that has 1000 datasets and is resilvering an HDD. [^1]: openzfs#9115 [^2]: openzfs#8987 [^3]: freebsd/freebsd-src@10b9d77 [^4]: illumos/illumos-gate@5aaeed5 [^5]: openzfs#7795 Sponsored by: Axcient Reviewed-by: Allan Jude <allan@klarasystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#16268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds support for FreeBSD to ZoL. Adding FreeBSD support to ZoL will make it easier to move changes back and forth between FreeBSD and Linux.
Description
How Has This Been Tested?
Adapted ZTS and have all tests that pass on HEAD passing on ZoF. Allan Jude and some developers have been using it personally.
Types of changes
Checklist:
Signed-off-by.