Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop redundant POSIX ACL check in zpl_init_acl() #9009

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Drop redundant POSIX ACL check in zpl_init_acl() #9009

merged 1 commit into from
Jul 15, 2019

Conversation

kusumi
Copy link
Member

@kusumi kusumi commented Jul 9, 2019

Motivation and Context

Description

ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@kusumi
Drop redundant POSIX ACL check in zpl_init_acl()
fa8b0f4 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 9, 2019
@codecov
Copy link

codecov bot commented Jul 10, 2019 •
edited
Loading

Codecov Report

Merging #9009 into master will increase coverage by 0.18%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9009      +/-   ##
==========================================
+ Coverage    78.5%   78.69%   +0.18%     
==========================================
  Files         401      401              
  Lines      120145   120145              
==========================================
+ Hits        94322    94547     +225     
+ Misses      25823    25598     -225
Flag Coverage Δ
#kernel 79.5% <50%> (+0.12%) ⬆️
#user 66.26% <ø> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d20b76...fa8b0f4. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 15, 2019
@behlendorf behlendorf merged commit 6993e01 into openzfs:master Jul 15, 2019
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
@kusumi
Drop redundant POSIX ACL check in zpl_init_acl()
9a023b2 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
@kusumi
Drop redundant POSIX ACL check in zpl_init_acl()
0bf9653 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
e0e6711 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
cccd9cc 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
42d9df6 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
80b800d 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
ef84dce 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
4a0548e 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
6ae59bf 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9009
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@kusumi @tonyhutter
Drop redundant POSIX ACL check in zpl_init_acl()
73e50a7 
ZFS_ACLTYPE_POSIXACL has already been tested in zpl_init_acl(),
so no need to test again on POSIX ACL access.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes #9009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

@behlendorf behlendorf behlendorf approved these changes

@ofaaland ofaaland Awaiting requested review from ofaaland

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kusumi @behlendorf @tonyhutter