Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dsl_destroy_head() decrypts objsets #9021

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Ensure dsl_destroy_head() decrypts objsets #9021

merged 1 commit into from
Jul 15, 2019

Conversation

tcaputi
Copy link
Contributor

@tcaputi tcaputi commented Jul 11, 2019

This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Signed-off-by: Tom Caputi tcaputi@datto.com

Motivation and Context

I found this issue while working on a bug with #9007. As far as I know it hasn't been reported in the real world yet, although I imagine it might if someone has async_destroy disabled and encryption enabled for whatever reason.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Ensure dsl_destroy_head() decrypts objsets
53ec7f8 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Signed-off-by: Tom Caputi <tcaputi@datto.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 12, 2019 •
edited
Loading

Codecov Report

Merging #9021 into master will decrease coverage by 0.08%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9021      +/-   ##
==========================================
- Coverage   78.66%   78.57%   -0.09%     
==========================================
  Files         401      401              
  Lines      120146   120146              
==========================================
- Hits        94514    94408     -106     
- Misses      25632    25738     +106
Flag Coverage Δ
#kernel 79.44% <50%> (+0.01%) ⬆️
#user 66.13% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d230a65...53ec7f8. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 15, 2019
@behlendorf behlendorf merged commit 9949b85 into openzfs:master Jul 15, 2019
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
Ensure dsl_destroy_head() decrypts objsets
784882c 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
Ensure dsl_destroy_head() decrypts objsets
d7018e6 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
b8e7a0d 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
808f515 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
65fbd17 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
0331d3b 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
de74498 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
eb3b41a 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
6d21dde 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes openzfs#9021
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@tonyhutter
Ensure dsl_destroy_head() decrypts objsets
78831d4 
This patch corrects a small issue where the dsl_destroy_head()
code that runs when the async_destroy feature is disabled would
not properly decrypt the dataset before beginning processing.
If the dataset is not able to be decrypted, the optimization
code now simply does not run and the dataset is completely
destroyed in the DSL sync task.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #9021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcaputi @behlendorf