Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export dnode symbols #9027

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Export dnode symbols #9027

merged 1 commit into from
Jul 15, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #8994. Lustre needs to be able to manipulate dnodes using
the same interfaces as the rest of the ZFS code.

Description

External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes. Export a subset
of the external functions.

How Has This Been Tested?

Locally compiled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 12, 2019
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 12, 2019
@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #9027 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9027      +/-   ##
==========================================
+ Coverage   78.62%   78.85%   +0.22%     
==========================================
  Files         401      401              
  Lines      120158   120158              
==========================================
+ Hits        94476    94752     +276     
+ Misses      25682    25406     -276
Flag Coverage Δ
#kernel 79.46% <ø> (+0.05%) ⬆️
#user 66.81% <ø> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5db313...588454d. Read the comment docs.

@behlendorf behlendorf merged commit 64f3d39 into openzfs:master Jul 15, 2019
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#8994
Closes openzfs#9027
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
External consumers such as Lustre require access to the dnode
interfaces in order to correctly manipulate dnodes.

Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #8994
Closes #9027
@behlendorf behlendorf deleted the dnode_symbols branch April 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants