Don't wakeup unnecessarily in 'zpool events -f' #9091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DHE <git@dehacked.net>
|
Is there a good reason for the polling-wait? I can't think of one. |
Codecov Report
@@ Coverage Diff @@
## master #9091 +/- ##
==========================================
+ Coverage 70.83% 79.07% +8.24%
==========================================
Files 351 401 +50
Lines 115431 121648 +6217
==========================================
+ Hits 81760 96189 +14429
+ Misses 33671 25459 -8212
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Jul 29, 2019
tonyhutter
approved these changes
Jul 29, 2019
behlendorf
added
Status: Accepted
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Aug 12, 2019
ZED can prevent CPU's from properly sleeping. Rather than periodically waking up in the zevents code, just go to sleep and wait for a wakeup. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: DHE <git@dehacked.net> Closes openzfs#9091
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Oct 13, 2019
ZED can prevent CPU's from properly sleeping. Rather than periodically waking up in the zevents code, just go to sleep and wait for a wakeup. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: DHE <git@dehacked.net> Closes openzfs#9091
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 24, 2019
ZED can prevent CPU's from properly sleeping. Rather than periodically waking up in the zevents code, just go to sleep and wait for a wakeup. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: DHE <git@dehacked.net> Closes openzfs#9091
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
ZED can prevent CPU's from properly sleeping. Rather than periodically waking up in the zevents code, just go to sleep and wait for a wakeup. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: DHE <git@dehacked.net> Closes openzfs#9091
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
ZED can prevent CPU's from properly sleeping. Rather than periodically waking up in the zevents code, just go to sleep and wait for a wakeup. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: DHE <git@dehacked.net> Closes #9091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: DHE git@dehacked.net
Motivation and Context
A user in IRC came in complaining that
zedwas preventing his laptop CPU from properly sleeping. Traced it down to this.Description
Rather than quasi-busy-waiting in the zevents code, just go to sleep and wait for a wakeup.
How Has This Been Tested?
Build-tested only at this point. It's late as I type this.
Types of changes
Checklist:
Signed-off-by.