Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup in Makefile.am #9189

Merged
merged 1 commit into from Aug 21, 2019
Merged

Minor cleanup in Makefile.am #9189

merged 1 commit into from Aug 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2019

Motivation and Context

Performing some code cleanup separately from the FreeBSD PR to reduce the diff.

Description

Split long lines where adding license info to dist archive.
Remove extra colon from target line.

How Has This Been Tested?

It still builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Split long lines where adding license info to dist archive.

Remove extra colon from target line.

Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #9189 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9189      +/-   ##
==========================================
- Coverage   79.05%   79.01%   -0.04%     
==========================================
  Files         400      400              
  Lines      122000   122000              
==========================================
- Hits        96443    96401      -42     
- Misses      25557    25599      +42
Flag Coverage Δ
#kernel 79.72% <ø> (-0.01%) ⬇️
#user 66.57% <ø> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325d288...ee41ea7. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 21, 2019
@behlendorf behlendorf merged commit f66a1f8 into openzfs:master Aug 21, 2019
@ghost ghost deleted the makefile-cleanup branch August 21, 2019 16:13
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
Split long lines where adding license info to dist archive.

Remove extra colon from target line.

Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#9189
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
Split long lines where adding license info to dist archive.

Remove extra colon from target line.

Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#9189
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
Split long lines where adding license info to dist archive.

Remove extra colon from target line.

Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes #9189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants