Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Fix vdev_zaps_005_pos on CentOS 6 #9199

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Resolve vdev_zaps_005_pos test failure when running on CentOS 6.
Observed by the CI.

Description

The ancient version of blkid (v2.17.2) used in CentOS 6 will not
detect the newly created pool unless it has been written to.
Force a pool sync so zpool import will detect the newly created
pool.

How Has This Been Tested?

Locally in a CentOS 6 VM.

$ ./scripts/zfs-tests.sh -t tests/functional/vdev_zaps/vdev_zaps_005_pos
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/vdev_zaps/setup (run as root) [00:00] [PASS]
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/vdev_zaps/vdev_zaps_005_pos (run as root) [00:07] [PASS]
Test: /home/behlendo/src/git/zfs/tests/zfs-tests/tests/functional/vdev_zaps/cleanup (run as root) [00:00] [PASS]

Results Summary
PASS	   3

Running Time:	00:00:08
Percent passed:	100.0%
Log directory:	/var/tmp/test_results/20190821T141509

Tests with results other than PASS that are expected:

Tests with result of PASS that are unexpected:

Tests with results other than PASS that are unexpected:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

The ancient version of blkid (v2.17.2) used in CentOS 6 will not
detect the newly created pool unless it has been written to.
Force a pool sync so `zpool import` will detect the newly created
pool.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 21, 2019
@behlendorf behlendorf requested a review from jwk404 August 22, 2019 00:17
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #9199 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9199      +/-   ##
==========================================
- Coverage   79.22%   78.98%   -0.24%     
==========================================
  Files         400      400              
  Lines      122001   122001              
==========================================
- Hits        96656    96368     -288     
- Misses      25345    25633     +288
Flag Coverage Δ
#kernel 79.74% <ø> (-0.01%) ⬇️
#user 66.57% <ø> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ebdfd...d5aed6b. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 22, 2019
@behlendorf behlendorf merged commit 20f7b91 into openzfs:master Aug 22, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
The ancient version of blkid (v2.17.2) used in CentOS 6 will not
detect the newly created pool unless it has been written to.
Force a pool sync so `zpool import` will detect the newly created
pool.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9199
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
The ancient version of blkid (v2.17.2) used in CentOS 6 will not
detect the newly created pool unless it has been written to.
Force a pool sync so `zpool import` will detect the newly created
pool.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9199
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
The ancient version of blkid (v2.17.2) used in CentOS 6 will not
detect the newly created pool unless it has been written to.
Force a pool sync so `zpool import` will detect the newly created
pool.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #9199
@behlendorf behlendorf deleted the zts-vdev_zaps_005_pos branch April 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants