Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in tests/ #9249

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix typos in tests/ #9249

merged 1 commit into from
Sep 3, 2019

Conversation

Gelma
Copy link
Contributor

@Gelma Gelma commented Aug 29, 2019

No description provided.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 29, 2019
@Gelma
Fix typos in tests/
7f7c5e6 
Thanks a lot for patch review to @freqlabs

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
rlaager
rlaager approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides one optional comment.

tests/zfs-tests/tests/functional/cli_root/zfs_property/zfs_written_property_001_pos.ksh Show resolved Hide resolved
rlaager
rlaager approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my perspective

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 3, 2019
@behlendorf behlendorf merged commit cb14aa4 into openzfs:master Sep 3, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
@Gelma @tonyhutter
Fix typos in tests/
5bed3ac 
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Closes openzfs#9249
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@Gelma @tonyhutter
Fix typos in tests/
e01cf9b 
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Closes openzfs#9249
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@Gelma @tonyhutter
Fix typos in tests/
2af76a2 
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Closes #9249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@rlaager rlaager rlaager approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gelma @rlaager @behlendorf