Linux 5.0 compat: SIMD compatibility (zfs-0.8-release) #9515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
the
Type: Performance
|
Does this still permit people who have re-exported the relevant kernel symbol to use that codepath? IIRC, grsec re-exports the originally un-exported symbol, and so do all of our branches. |
|
@sempervictus yes it does. If the kernel exports the needed symbols they will be used. You can verify this in the configure output: Using provided kernel symbols (one of these): Using internal ZFS implementation: Optimizations are disabled: |
Restore the SIMD optimization for 4.19.38 LTS, 4.14.120 LTS, and 5.0 and newer kernels. This commit squashes the following commits from master in to a single commit which can be applied to 0.8.2. 10fa254 - Linux 4.14, 4.19, 5.0+ compat: SIMD save/restore b88ca2a - Enable SIMD for encryption 095b541 - Fix CONFIG_X86_DEBUG_FPU build failure e5db313 - Linux 5.0 compat: SIMD compatibility Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> TEST_ZIMPORT_SKIP="yes"
behlendorf
force-pushed
the
zfs-0.8.2-simd-squash
branch
from
3dc9472
to
4f9e825
Compare
This was referenced Oct 28, 2019
|
What's the state of this? I see very high |
10 tasks
fxsave and xsave require the target address to be 16-/64-byte aligned. kmalloc(_node) does not (yet) offer such fine-grained control over alignment[0,1], even though it does "the right thing" most of the time for power-of-2 sizes. unfortunately, alignment is completely off when using certain debugging or hardening features/configs, such as KASAN, slub_debug=Z or the not-yet-upstream SLAB_CANARY. Use alloc_pages_node() instead which allows us to allocate page-aligned memory. Since fpregs_state is padded to a full page anyway, and this code is only relevant for x86 which has 4k pages, this approach should not allocate any unnecessary memory but still guarantee the needed alignment. 0: https://lwn.net/Articles/787740/ 1: https://lore.kernel.org/linux-block/20190826111627.7505-1-vbabka@suse.cz/ Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#9608 Closes openzfs#9674
|
@nh2 this is now ready for inclusion in 0.8.3. One additional commit has been added to resolve an issue which only manifests itself with some Linux kernel debug options. |
|
Closing. These changes have been included in #9776. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Backport of the SIMD patches merged to master for inclusion in
the 0.8.x series. Opened for a full CI run.
Description
Restore the SIMD optimization for 4.19.38 LTS, 4.14.120 LTS,
and 5.0 and newer kernels.
This commit squashes the following commits from master in to
a single commit which can be applied to 0.8.2.
10fa254 - Linux 4.14, 4.19, 5.0+ compat: SIMD save/restore
b88ca2a - Enable SIMD for encryption
095b541 - Fix CONFIG_X86_DEBUG_FPU build failure
e5db313 - Linux 5.0 compat: SIMD compatibility
How Has This Been Tested?
Locally tested using the
mprime -ttorture tests while concurrentlywriting to and scrubbing an encrypted raidz2 pool. This exercises
the vector implementation for fletcher4, aes, and raidz parity calculations.
No failures were reported by
mprime -tafter several hours of run time.Types of changes
Checklist:
Signed-off-by.