Add a notice in /etc/defaults/zfs for systemd users. #9544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
reviewed
Nov 1, 2019
There was a problem hiding this comment.
Thank you for the PR to improve our documentation. This looks great, would you just mind force updating the PR to include you signed-off-by in the commit message.
git commit --amend -s
git push --force ...
The commit message should include Signed-off-by: Name <email>.
behlendorf
added
Status: Code Review Needed
Signed-off-by: Mo Zhou <cdluminate@gmail.com>
|
@behlendorf Done. Thanks for the tips about |
behlendorf
approved these changes
Nov 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #9544 +/- ##
==========================================
+ Coverage 79.01% 79.06% +0.04%
==========================================
Files 418 417 -1
Lines 123686 123678 -8
==========================================
+ Hits 97736 97788 +52
+ Misses 25950 25890 -60
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
Some systemd users may want to change configurations in /etc/defaults/zfs, but these settings won't affect systemd services. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Mo Zhou <cdluminate@gmail.com> Closes openzfs#9544
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
Some systemd users may want to change configurations in /etc/defaults/zfs, but these settings won't affect systemd services. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Mo Zhou <cdluminate@gmail.com> Closes openzfs#9544
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Some systemd users may want to change configurations in /etc/defaults/zfs, but these settings won't affect systemd services. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Mo Zhou <cdluminate@gmail.com> Closes #9544
jackpot51
pushed a commit
to pop-os/zfs-linux
that referenced
this pull request
Jan 20, 2022
Gbp-Dch: Ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systemd users may want to change configurations in
/etc/defaults/zfs, but someof these settings won't affect systemd services, etc. As reported here
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901436
Motivation and Context
Notify the user if they intend to edit this file.
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.