Implement -A (ignore ASSERTs) for zdb #9610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Zuchowski <pzuchowski@datto.com>
12 tasks
behlendorf
approved these changes
Nov 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #9610 +/- ##
==========================================
+ Coverage 79.19% 79.22% +0.03%
==========================================
Files 418 418
Lines 123531 123548 +17
==========================================
+ Hits 97828 97880 +52
+ Misses 25703 25668 -35
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
12 tasks
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
The command line switch -A (ignore ASSERTs) has always been available in zdb but was never connected up to the correct global variable. There are times when you need zdb to ignore asserts and keep dumping out whatever information it can get despite the ASSERT(s) failing. It was always intended to be part of zdb but was incomplete. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes openzfs#9610
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
The command line switch -A (ignore ASSERTs) has always been available in zdb but was never connected up to the correct global variable. There are times when you need zdb to ignore asserts and keep dumping out whatever information it can get despite the ASSERT(s) failing. It was always intended to be part of zdb but was incomplete. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes openzfs#9610
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
The command line switch -A (ignore ASSERTs) has always been available in zdb but was never connected up to the correct global variable. There are times when you need zdb to ignore asserts and keep dumping out whatever information it can get despite the ASSERT(s) failing. It was always intended to be part of zdb but was incomplete. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes #9610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement -A (ignore ASSERTs) for zdb
The command line switch -A (ignore ASSERTs) has always been available in zdb but was never connected up to the correct global variable.
Signed-off-by: Paul Zuchowski pzuchowski@datto.com
Motivation and Context
There are times when you need zdb to ignore asserts and keep dumping out whatever information it can get despite the ASSERT(s) failing. It was always intended to be part of zdb but was incomplete.
Description
Change the code so the global variable aok was correctly set, and that the ASSERT code would obey it.
How Has This Been Tested?
Here is the test run I did. There won't be a zfs test for this because the assert demonstrated here is going to be fixed.
# zdb -R tank 0:2a856400:600:id
Found vdev: /root/file1
Trying 00600 -> 00800 (inherit)
ret == 0 (0x16 == 0)
ASSERT at ../../module/zfs/zio_compress.c:162:zio_decompress_data()
#
# zdb -A -R tank 0:2a856400:600:id
DVA[0]=<0:2a850400:400> [L0 ZFS plain file] fletcher4 uncompressed unencrypted LE contiguous unique single size=400L/400P birth=277331L/277331P fill=1 cksum=4b20aef2a3:26cc1e35cd35:d2f34b21245fb:3595d44a25c6c4e
DVA[0]=<0:2a850800:400> [L0 ZFS plain file] fletcher4 uncompressed unencrypted LE contiguous unique single size=400L/400P birth=277331L/277331P fill=1 cksum=49959161
02:254bdc23fb93:ca43590452f0b:33a52770fdf8ed3
...
Types of changes
Checklist:
Signed-off-by.