Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use-after-free in case of L2ARC prefetch failure. #9648

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Fix use-after-free in case of L2ARC prefetch failure. #9648

merged 1 commit into from
Dec 3, 2019

Commits on Dec 2, 2019

  1. Fix use-after-free in case of L2ARC prefetch failure. 

    In case L2ARC read failed, l2arc_read_done() creates _different_ ZIO
to read data from the original storage device.  Unfortunately pointer
to the failed ZIO remains in hdr->b_l1hdr.b_acb->acb_zio_head, and if
some other read try to bump the ZIO priority, it will crash.

The problem is reproducible by corrupting L2ARC content and reading
some data with prefetch if l2arc_noprefetch tunable is changed to 0.
With the default setting the issue is probably not reproducible now.

Sponsored-By: iXsystems, Inc.
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
    @amotin
    amotin committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    164b2c0 View commit details
    Browse the repository at this point in the history