set send_realloc_files.ksh to use properties.shlib #9679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets send_realloc_files.ksh to use properties.shlib (like the other compression related tests) It was missing from openzfs#9645 Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
behlendorf
approved these changes
Dec 4, 2019
behlendorf
added
Status: Code Review Needed
Codecov Report
@@ Coverage Diff @@
## master #9679 +/- ##
========================================
- Coverage 79% 79% -<1%
========================================
Files 418 418
Lines 123562 123562
========================================
- Hits 98093 98061 -32
- Misses 25469 25501 +32
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
This sets send_realloc_files.ksh to use properties.shlib (like the other compression related tests) It was missing from openzfs#9645 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl> Issue openzfs#9645 Closes openzfs#9679
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
This sets send_realloc_files.ksh to use properties.shlib (like the other compression related tests) It was missing from openzfs#9645 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl> Issue openzfs#9645 Closes openzfs#9679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets send_realloc_files.ksh to use properties.shlib
(like the other compression related tests)
It was missing from #9645
Signed-off-by: Kjeld Schouten-Lebbing kjeld@schouten-lebbing.nl
Motivation and Context
I don't know how I missed it, but I missed this file while doing PR #9645
This does however make pretty clear how easy it was to forget references in the previous way compression algorithms where referenced in tests.
Description
So I just applied the same basics as #9645 to send_realloc_files.ksh
How Has This Been Tested?
Automatic testing
Types of changes
Checklist:
Signed-off-by.