Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude data from cores unconditionally and metadata conditionally #9691

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Exclude data from cores unconditionally and metadata conditionally #9691

merged 1 commit into from
Dec 9, 2019

Conversation

mattmacy
Copy link
Contributor

@mattmacy mattmacy commented Dec 7, 2019

Signed-off-by: Matt Macy mmacy@FreeBSD.org

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mattmacy
Exclude data from cores unconditionally and metadata conditionally
d52dcd2 
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 7, 2019
lundman
lundman approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@lundman lundman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting, I should see if I can do the right thing for KMC_NODEBUG on osx.

@behlendorf
Copy link
Contributor

@lundman it's not wired up on the Linux side either.

@codecov
Copy link

codecov bot commented Dec 7, 2019 •
edited
Loading

Codecov Report

Merging #9691 into master will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #9691    +/-   ##
========================================
- Coverage      79%      79%   -<1%     
========================================
  Files         418      418            
  Lines      123572   123574     +2     
========================================
- Hits        98121    98074    -47     
- Misses      25451    25500    +49
Flag Coverage Δ
#kernel 80% <100%> (ø) ⬇️
#user 67% <100%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dcef9b...d52dcd2. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 9, 2019
@behlendorf behlendorf merged commit 3c502d3 into openzfs:master Dec 9, 2019
@mattmacy mattmacy deleted the projects/zio_exclude_metadata branch December 19, 2019 22:25
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
@mattmacy @tonyhutter
Exclude data from cores unconditionally and metadata conditionally
c930859 
This change allows us to align the code dump logic across platforms.

Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9691
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@mattmacy @tonyhutter
Exclude data from cores unconditionally and metadata conditionally
74dec73 
This change allows us to align the code dump logic across platforms.

Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9691
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@mattmacy @tonyhutter
Exclude data from cores unconditionally and metadata conditionally
d2233a0 
This change allows us to align the code dump logic across platforms.

Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Don Brady <don.brady@delphix.com>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes #9691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@don-brady don-brady don-brady approved these changes

@lundman lundman lundman approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattmacy @behlendorf @lundman @don-brady