Fixes for spurious failures of resilver_restart_001 test #9703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrivatePuffin
approved these changes
Dec 9, 2019
behlendorf
approved these changes
Dec 9, 2019
tests/zfs-tests/tests/functional/resilver/resilver_restart_001.ksh
Outdated
Show resolved
Hide resolved
behlendorf
requested changes
Dec 9, 2019
tests/zfs-tests/tests/functional/resilver/resilver_restart_001.ksh
Outdated
Show resolved
Hide resolved
behlendorf
added
Status: Code Review Needed
The resilver restart test was reported as failing about 2% of the time. Two issues were found: - The event log wasn't large enough, so resilver events were missing - One 'zpool sync' wasn't enough for resilver to start after zinject Signed-off-by: John Poduska <jpoduska@datto.com> Closes openzfs#9677
jwpoduska
force-pushed
the
resilver_test_fix
branch
from
8fcd29b
to
327a92b
Compare
behlendorf
added
Status: Accepted
Codecov Report
@@ Coverage Diff @@
## master #9703 +/- ##
========================================
- Coverage 79% 79% -<1%
========================================
Files 418 418
Lines 123577 123577
========================================
- Hits 97951 97880 -71
- Misses 25626 25697 +71
Continue to review full report at Codecov.
|
jwk404
approved these changes
Dec 10, 2019
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 22, 2020
The resilver restart test was reported as failing about 2% of the time. Two issues were found: - The event log wasn't large enough, so resilver events were missing - One 'zpool sync' wasn't enough for resilver to start after zinject Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: John Poduska <jpoduska@datto.com> Issue openzfs#9588 Closes openzfs#9677 Closes openzfs#9703
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
The resilver restart test was reported as failing about 2% of the time. Two issues were found: - The event log wasn't large enough, so resilver events were missing - One 'zpool sync' wasn't enough for resilver to start after zinject Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: John Poduska <jpoduska@datto.com> Issue #9588 Closes #9677 Closes #9703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Poduska jpoduska@datto.com
Closes #9677
Motivation and Context
This PR fixes spurious failures to a new test introduced by zfsonlinux#9588, as reported in zfsonlinux#9677.
Description
The resilver restart test was reported as failing about 2% of the time.
Issues found:
How Has This Been Tested?
The test has been run by itself over one thousand times without failure.
Types of changes
Checklist:
Signed-off-by.