Fix zfs_rmnode() unlink / rollback issue #9739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2019
behlendorf
force-pushed
the
issue-6812
branch
from
8898c91
to
dbfb35a
Compare
Codecov Report
@@ Coverage Diff @@
## master #9739 +/- ##
========================================
+ Coverage 79% 79% +<1%
========================================
Files 385 385
Lines 121610 121611 +1
========================================
+ Hits 96429 96525 +96
+ Misses 25181 25086 -95
Continue to review full report at Codecov.
|
behlendorf
force-pushed
the
issue-6812
branch
from
dbfb35a
to
058a10d
Compare
If a has rollback has occurred while a file is open and unlinked. Then when the file is closed post rollback it will not exist in the rolled back version of the unlinked object. Therefore, the call to zap_remove_int() may correctly return ENOENT and should be allowed. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
behlendorf
force-pushed
the
issue-6812
branch
from
058a10d
to
62f5a31
Compare
behlendorf
added
Status: Accepted
|
@behlendorf Should this be in 0.8.X ? Since we are still seeing: #9741 on 0.8.3 |
|
@bgly yes, that's a good idea. It has had enough soak time now in master. |
bgly
pushed a commit
to buurst/zfs
that referenced
this pull request
Jun 25, 2020
If a has rollback has occurred while a file is open and unlinked. Then when the file is closed post rollback it will not exist in the rolled back version of the unlinked object. Therefore, the call to zap_remove_int() may correctly return ENOENT and should be allowed. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#6812 Closes openzfs#9739
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
If a has rollback has occurred while a file is open and unlinked. Then when the file is closed post rollback it will not exist in the rolled back version of the unlinked object. Therefore, the call to zap_remove_int() may correctly return ENOENT and should be allowed. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#6812 Closes openzfs#9739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue #6812.
Description
If a has rollback has occurred while a file is open and unlinked.
Then when the file is closed post rollback it will not exist in the
rolled back version of the unlinked object. Therefore, the call to
zap_remove_int() may correctly return ENOENT and should be allowed.
How Has This Been Tested?
Minimally, locally I performed some basic testing but was unable
to reproduce the original issue. This may be because I was only
testing using master which includes additional changes in this area.
Or because in my manual testing I wasn't able exactly force the
described scenario.
Types of changes
Checklist:
Signed-off-by.