-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test pattern in zts-report.py #9750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for running this down. It'll be interesting to get a full test run to see what may have slipped in. We may need to hold off on this one briefly until things like #9748, and perhaps others, are merged.
336d3c1
to
7b72156
Compare
|
That's good, early results suggest that only the handful of tests from #9748 were impacted. Since those fixes are now merged, if you rebase this you should get a clean run.
|
The pattern was not updated to match when the test output changed to include a platform identifier for platform specfic tests. Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
7b72156
to
27df83d
Compare
Codecov Report
@@ Coverage Diff @@
## master #9750 +/- ##
========================================
- Coverage 80% 80% -<1%
========================================
Files 385 385
Lines 121470 121470
========================================
- Hits 96667 96640 -27
- Misses 24803 24830 +27
Continue to review full report at Codecov.
|
Signed-off-by: Ryan Moeller ryan@ixsystems.com
Motivation and Context
The regex pattern to extract test results from the test runner was not updated to match when the test output changed to include a platform identifier for platform specific tests. This caused failing platform-specific tests to be missed.
Description
Add an optional non-capturing group to match the platform identifier.
How Has This Been Tested?
Manually ran zfs-test.sh for various tags to confirm correct operation:
attr
tool, some pass some fail, failed tests are caughtTypes of changes
Checklist:
Signed-off-by
.