Restore aclmode and remove acltype on FreeBSD #9913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
amotin
approved these changes
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #9913 +/- ##
========================================
+ Coverage 79% 79% +<1%
========================================
Files 384 384
Lines 121788 121788
========================================
+ Hits 96645 96675 +30
+ Misses 25143 25113 -30
Continue to review full report at Codecov.
|
ghost
marked this pull request as ready for review
This replaces the placeholder ZFS_PROP_PRIVATE with ZFS_PROP_ACLMODE, matching what is done in the NFSv4 ACLs PR (openzfs#9709). On FreeBSD we hide ZFS_PROP_ACLTYPE, while on Linux we hide ZFS_PROP_ACLMODE. The tests already assume this arrangement. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
force-pushed
the
freebsd-aclmode
branch
from
080edcc
to
fc386c7
Compare
|
behlendorf
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
We'd originally delayed making this change since some additional changes in #9709 are required to actually support "aclmode". But since this doesn't really change anything on the Linux side, and we're considerably father along with the FreeBSD work, I agree we can go ahead with this change now.
behlendorf
added
Status: Accepted
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
This replaces the placeholder ZFS_PROP_PRIVATE with ZFS_PROP_ACLMODE, matching what is done in the NFSv4 ACLs PR (openzfs#9709). On FreeBSD we hide ZFS_PROP_ACLTYPE, while on Linux we hide ZFS_PROP_ACLMODE. The tests already assume this arrangement. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#9913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Linux at some point dropped the aclmode property and added acltype.
A placeholder ZFS_PROP_PRIVATE was put in place of ZFS_PROP_ACLMODE.
On FreeBSD we support the aclmode property, not acltype.
Description
This patch replaces the placeholder ZFS_PROP_PRIVATE with ZFS_PROP_ACLMODE, matching what is done in the NFSv4 ACLs PR (#9709).
On FreeBSD we hide ZFS_PROP_ACLTYPE, while on Linux we hide ZFS_PROP_ACLMODE.
The tests already assume this arrangement.
How Has This Been Tested?
I ran the zfs_get tag of tests manually, full ZTS run looks clean.
Types of changes
Checklist:
Signed-off-by.