Change ZVOL to use _by_dnode() methods #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continues what was started in 0eef1bde31d67091d3deed23fe2394f5a8bf2276 by fully converting zvols to avoid unnecessary dnode_hold() calls. This saves a small amount of CPU time and slightly improves latencies of operations on zvols. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@prophetstor.com> Closes #6058 Porting-notes: Cleaned up previous style, which was based on OSX. Since we can use the standard uio call, we should take advantage of that. Additionally deleted all the symlink code, as that is specific to OSX. Ported-by: Jorgen Lundman <lundman@lundman.net>
We can improve the performance of writes to zvols by using dmu_tx_hold_write_by_dnode() instead of dmu_tx_hold_write(). This reduces lock contention on the first block of the dnode object, and also reduces the amount of CPU needed. The benefit will be highest with multi-threaded async writes (i.e. writes that don't call zil_commit()). Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
$ ./zfs create -s -V 3GB -b 2048 tank/vol Warning: volblocksize (2048) < ashift (12 / 4096) means all writes are amplified and space wasted.
lundman
commented
Apr 11, 2020
| "volblocksize (%llu) < ashift (%llu / %llu)\n" | ||
| "means all writes are amplified and space wasted.\n"), | ||
| blocksize, ashift, 1ULL << ashift); | ||
| } |
There was a problem hiding this comment.
@ahrens You might want to de-ESOL the text... :)
|
Waiting for approval in openzfs/zfs#10199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which reduces the contention behind the ZVOL_OBJ mutex.