Skip to content

Commit

Permalink
Windows: can we keep offset+length separate?
Browse files Browse the repository at this point in the history
It would be nice to not have to encode the device name with
but rather, keep offset+length in the "rn" struct. But in
zpool_find_import_impl() the rn list is converted into nvlists, and
freed. We would need to also copy offset+length into nvlists.
(This current attempt tries to locate the partition meant in the
update_vdev_config_dev_strs() by re-reading the EFI label and matching
guid. This falls apart with "zpool create", as there is no partition or
matching guid yet.

So we can either add the nvlist properties, and attempt to pass it
along. Hopefully the nvlists are not stored on disks.

Or we comment out the last-ditch open() test done in
zpool_find_import_impl(), or fix up
open() to handle #offset#size#name.

This commit will be reverted next.
  • Loading branch information
lundman committed Feb 12, 2021
1 parent 788bc3d commit d1c023c
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 263 deletions.
Loading

0 comments on commit d1c023c

Please sign in to comment.