Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for cstyle. #13

Merged
merged 2 commits into from
Apr 6, 2021
Merged

fix for cstyle. #13

merged 2 commits into from
Apr 6, 2021

Conversation

lundman
Copy link

@lundman lundman commented Mar 25, 2021

Had to guess some things. Move ident in made some places nicer.

Kajerik Lundman and others added 2 commits March 25, 2021 16:14
@lundman
fix for cstyle.
3ee1b56 
Had to guess some things. Move ident in made some places nicer.
@lundman
Correct typos in cstyle
a5170be 
Thanks for the mindless work
@lundman lundman merged commit 86dd83c into windows Apr 6, 2021
lundman added a commit that referenced this pull request Jul 1, 2021
@lundman
fix for cstyle. (#13)
37f4192 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
lundman added a commit that referenced this pull request Jul 2, 2021
@lundman
fix for cstyle. (#13)
c19ad95 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
lundman added a commit that referenced this pull request Feb 21, 2022
@lundman
fix for cstyle. (#13)
939e008 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Jul 30, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
f8982ed 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
97f50c4 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
ff5befb 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
a25c24e 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
4df58f8 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
611eed1 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
6656147 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
580a402 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
2789cd3 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
b3738fc 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
40625b1 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
be1e00d 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
a462996 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
7252469 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
39a7ff3 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
02fc974 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
dc8e526 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
b586410 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
5353f80 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
9e11703 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
a95dede 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
8243fae 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
d59d9cb 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Aug 27, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
25efbbc 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
f45ac20 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
2421261 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
386fdce 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
357cd88 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
bddaf3d 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
06b2809 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
3d8fc54 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
7297c5c 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
41b4209 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
9b980cb 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
dfea828 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
aa51ed2 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Sep 23, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
e5547a8 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
a6292e5 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
defb64e 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
e864f9e 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
5c2aaa6 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
318e208 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
1748fd7 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
d6729ce 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
fbf891d 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
55110c7 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 1, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
cb625a0 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 2, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
8a7fb6b 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 6, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
35280cb 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 6, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
7368c25 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 6, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
d380b9e 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
andrewc12 referenced this pull request in andrewc12/openzfs Oct 9, 2022
@lundman @andrewc12
fix for cstyle. (openzfs#13)
194cbfb 
This is a large commit, but it should have no functional changes, just cstyle corrections.

* fix for cstyle.

Had to guess some things. Move ident in made some places nicer.

* Correct typos in cstyle

Thanks for the mindless work

Co-authored-by: Kajerik Lundman <kajerik@lundman.net>
lundman pushed a commit that referenced this pull request Mar 3, 2023
@rob-wing
FreeBSD: don't verify recycled vnode for zfs control directory
28251d8 
Under certain loads, the following panic is hit:

    panic: page fault
    KDB: stack backtrace:
    #0 0xffffffff805db025 at kdb_backtrace+0x65
    #1 0xffffffff8058e86f at vpanic+0x17f
    #2 0xffffffff8058e6e3 at panic+0x43
    #3 0xffffffff808adc15 at trap_fatal+0x385
    #4 0xffffffff808adc6f at trap_pfault+0x4f
    #5 0xffffffff80886da8 at calltrap+0x8
    #6 0xffffffff80669186 at vgonel+0x186
    #7 0xffffffff80669841 at vgone+0x31
    #8 0xffffffff8065806d at vfs_hash_insert+0x26d
    #9 0xffffffff81a39069 at sfs_vgetx+0x149
    #10 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #11 0xffffffff8065a28c at lookup+0x45c
    #12 0xffffffff806594b9 at namei+0x259
    #13 0xffffffff80676a33 at kern_statat+0xf3
    #14 0xffffffff8067712f at sys_fstatat+0x2f
    #15 0xffffffff808ae50c at amd64_syscall+0x10c
    #16 0xffffffff808876bb at fast_syscall_common+0xf8

The page fault occurs because vgonel() will call VOP_CLOSE() for active
vnodes. For this reason, define vop_close for zfsctl_ops_snapshot. While
here, define vop_open for consistency.

After adding the necessary vop, the bug progresses to the following
panic:

    panic: VERIFY3(vrecycle(vp) == 1) failed (0 == 1)
    cpuid = 17
    KDB: stack backtrace:
    #0 0xffffffff805e29c5 at kdb_backtrace+0x65
    #1 0xffffffff8059620f at vpanic+0x17f
    #2 0xffffffff81a27f4a at spl_panic+0x3a
    #3 0xffffffff81a3a4d0 at zfsctl_snapshot_inactive+0x40
    #4 0xffffffff8066fdee at vinactivef+0xde
    #5 0xffffffff80670b8a at vgonel+0x1ea
    #6 0xffffffff806711e1 at vgone+0x31
    #7 0xffffffff8065fa0d at vfs_hash_insert+0x26d
    #8 0xffffffff81a39069 at sfs_vgetx+0x149
    #9 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #10 0xffffffff80661c2c at lookup+0x45c
    #11 0xffffffff80660e59 at namei+0x259
    #12 0xffffffff8067e3d3 at kern_statat+0xf3
    #13 0xffffffff8067eacf at sys_fstatat+0x2f
    #14 0xffffffff808b5ecc at amd64_syscall+0x10c
    #15 0xffffffff8088f07b at fast_syscall_common+0xf8

This is caused by a race condition that can occur when allocating a new
vnode and adding that vnode to the vfs hash. If the newly created vnode
loses the race when being inserted into the vfs hash, it will not be
recycled as its usecount is greater than zero, hitting the above
assertion.

Fix this by dropping the assertion.

FreeBSD-issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252700
Reviewed-by: Andriy Gapon <avg@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Alek Pinchuk <apinchuk@axcient.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Rob Wing <rob.wing@klarasystems.com>
Co-authored-by: Rob Wing <rob.wing@klarasystems.com>
Submitted-by: Klara, Inc.
Sponsored-by: rsync.net
Closes openzfs#14501
lundman pushed a commit that referenced this pull request Mar 3, 2023
@rob-wing @lundman
FreeBSD: don't verify recycled vnode for zfs control directory
52156d9 
Under certain loads, the following panic is hit:

    panic: page fault
    KDB: stack backtrace:
    #0 0xffffffff805db025 at kdb_backtrace+0x65
    #1 0xffffffff8058e86f at vpanic+0x17f
    #2 0xffffffff8058e6e3 at panic+0x43
    #3 0xffffffff808adc15 at trap_fatal+0x385
    #4 0xffffffff808adc6f at trap_pfault+0x4f
    #5 0xffffffff80886da8 at calltrap+0x8
    #6 0xffffffff80669186 at vgonel+0x186
    #7 0xffffffff80669841 at vgone+0x31
    #8 0xffffffff8065806d at vfs_hash_insert+0x26d
    #9 0xffffffff81a39069 at sfs_vgetx+0x149
    #10 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #11 0xffffffff8065a28c at lookup+0x45c
    #12 0xffffffff806594b9 at namei+0x259
    #13 0xffffffff80676a33 at kern_statat+0xf3
    #14 0xffffffff8067712f at sys_fstatat+0x2f
    #15 0xffffffff808ae50c at amd64_syscall+0x10c
    #16 0xffffffff808876bb at fast_syscall_common+0xf8

The page fault occurs because vgonel() will call VOP_CLOSE() for active
vnodes. For this reason, define vop_close for zfsctl_ops_snapshot. While
here, define vop_open for consistency.

After adding the necessary vop, the bug progresses to the following
panic:

    panic: VERIFY3(vrecycle(vp) == 1) failed (0 == 1)
    cpuid = 17
    KDB: stack backtrace:
    #0 0xffffffff805e29c5 at kdb_backtrace+0x65
    #1 0xffffffff8059620f at vpanic+0x17f
    #2 0xffffffff81a27f4a at spl_panic+0x3a
    #3 0xffffffff81a3a4d0 at zfsctl_snapshot_inactive+0x40
    #4 0xffffffff8066fdee at vinactivef+0xde
    #5 0xffffffff80670b8a at vgonel+0x1ea
    #6 0xffffffff806711e1 at vgone+0x31
    #7 0xffffffff8065fa0d at vfs_hash_insert+0x26d
    #8 0xffffffff81a39069 at sfs_vgetx+0x149
    #9 0xffffffff81a39c54 at zfsctl_snapdir_lookup+0x1e4
    #10 0xffffffff80661c2c at lookup+0x45c
    #11 0xffffffff80660e59 at namei+0x259
    #12 0xffffffff8067e3d3 at kern_statat+0xf3
    #13 0xffffffff8067eacf at sys_fstatat+0x2f
    #14 0xffffffff808b5ecc at amd64_syscall+0x10c
    #15 0xffffffff8088f07b at fast_syscall_common+0xf8

This is caused by a race condition that can occur when allocating a new
vnode and adding that vnode to the vfs hash. If the newly created vnode
loses the race when being inserted into the vfs hash, it will not be
recycled as its usecount is greater than zero, hitting the above
assertion.

Fix this by dropping the assertion.

FreeBSD-issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252700
Reviewed-by: Andriy Gapon <avg@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Alek Pinchuk <apinchuk@axcient.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Rob Wing <rob.wing@klarasystems.com>
Co-authored-by: Rob Wing <rob.wing@klarasystems.com>
Submitted-by: Klara, Inc.
Sponsored-by: rsync.net
Closes openzfs#14501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lundman