Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI and add aarch_dyn target. #784

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Update the CI and add aarch_dyn target. #784

merged 6 commits into from
Apr 20, 2023

Conversation

mgautierfr
Copy link
Collaborator

@mgautierfr mgautierfr commented Apr 19, 2023

Fix #702

This also remove a dependency to https://mirror.download.kiwix.org/dev/xz-5.2.1-wrap.zip as we now use (wrapdb) upstream wrap. (the same way we have fixed #663)

Depends of kiwix/kiwix-build#596

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -28.19 ⚠️

Comparison is base (5798d02) 84.25% compared to head (6859910) 56.07%.

❗ Current head 6859910 differs from pull request most recent head e88ae4d. Consider uploading reports for the commit e88ae4d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #784       +/-   ##
===========================================
- Coverage   84.25%   56.07%   -28.19%     
===========================================
  Files         101       98        -3     
  Lines        4625     4394      -231     
  Branches     1994     1910       -84     
===========================================
- Hits         3897     2464     -1433     
+ Misses        727      672       -55     
- Partials        1     1258     +1257     

see 83 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgautierfr mgautierfr force-pushed the aarch_ci branch 3 times, most recently from 8ae5d69 to 531c7ee Compare April 19, 2023 12:54
@mgautierfr mgautierfr marked this pull request as ready for review April 19, 2023 13:04
Let's use the same order of the `target` section.
Direct call to `meson` without setup is deprecated.
Last version of liblzma wrap doesn't have the option `enable_xz`.
Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 6210433 into main Apr 20, 2023
@kelson42 kelson42 deleted the aarch_ci branch April 20, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants