-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indexation of CJK languages. #806
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 57.49% 57.46% -0.03%
==========================================
Files 98 98
Lines 4526 4528 +2
Branches 1901 1903 +2
==========================================
Hits 2602 2602
Misses 674 674
- Partials 1250 1252 +2
☔ View full report in Codecov by Sentry. |
@mgautierfr Can you please provide an index size benchmark? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the commit containing the fix final? If yes, why does it have [WIP] in its title?
Also, do you have an explanation for why the codecov/patch flow has failed? |
For a unknown reason (maybe the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge without squashing the fixup commit.
Don't merge without squashing the fixup commit.
Don't merge without squashing the fixup commit.
Don't merge without squashing the fixup commit.
Fix #802