Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexation of CJK languages. #806

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Fix indexation of CJK languages. #806

merged 2 commits into from
Jun 8, 2023

Conversation

mgautierfr
Copy link
Collaborator

@mgautierfr mgautierfr commented Jun 7, 2023

Fix #802

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.03 ⚠️

Comparison is base (c9d5e9a) 57.49% compared to head (0f0016c) 57.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   57.49%   57.46%   -0.03%     
==========================================
  Files          98       98              
  Lines        4526     4528       +2     
  Branches     1901     1903       +2     
==========================================
  Hits         2602     2602              
  Misses        674      674              
- Partials     1250     1252       +2     
Impacted Files Coverage Δ
src/search.cpp 48.40% <0.00%> (ø)
src/writer/xapianIndexer.cpp 30.88% <0.00%> (-0.47%) ⬇️
src/writer/xapianWorker.cpp 32.50% <0.00%> (-0.84%) ⬇️
src/suggestion.cpp 45.38% <33.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgautierfr mgautierfr changed the title Add a unit test showing bug with CJK indexing. Fix indexation of CJK languages. Jun 7, 2023
@mgautierfr mgautierfr requested a review from veloman-yunkan June 7, 2023 13:31
@mgautierfr mgautierfr marked this pull request as ready for review June 7, 2023 13:32
@kelson42
Copy link
Contributor

kelson42 commented Jun 7, 2023

@mgautierfr Can you please provide an index size benchmark?
@xiaoyifang Could you please confirm this fix the issue you have open (hope you are able to build a test ZIM file)?

Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the commit containing the fix final? If yes, why does it have [WIP] in its title?

test/suggestion.cpp Outdated Show resolved Hide resolved
test/search.cpp Outdated Show resolved Hide resolved
@veloman-yunkan
Copy link
Collaborator

Also, do you have an explanation for why the codecov/patch flow has failed?

@mgautierfr
Copy link
Collaborator Author

Also, do you have an explanation for why the codecov/patch flow has failed?

For a unknown reason (maybe the assert at the beginning of function ?), codecov thinks the line are partially tested.
Maybe it is not totally counted as tested and, as we add new lines, the coverage decrease.

@mgautierfr mgautierfr requested a review from veloman-yunkan June 8, 2023 13:50
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge without squashing the fixup commit.
Don't merge without squashing the fixup commit.
Don't merge without squashing the fixup commit.
Don't merge without squashing the fixup commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CJK index creation and query
3 participants