Simplifies b3 single format by formalizing debug as a sampling status #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
grade-d
branch
from
aab6783 to
124b52a
Compare
codefromthecrypt
force-pushed
the
grade-d
branch
from
0602afd to
1942664
Compare
As discussed, this makes debug use the letter 'd' in the same slot as unsampled '0' or sampled '1'. The result is much simpler code and ideally more a more intuitive header.
codefromthecrypt
force-pushed
the
grade-d
branch
from
1942664 to
3bc82a0
Compare
|
I will revert this if the topic once settles goes in another direction. If we need to do a release prior to feedback, I'll make all the related types hidden until that's not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this makes debug use the letter 'd' in the same slot as
unsampled '0' or sampled '1'. The result is much simpler code and
ideally more a more intuitive header.
See openzipkin/b3-propagation#21 (comment)