Adds support for json encoding, notably zipkin2 format #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,7 +137,6 @@ private void sendSpansInternal(List<Span> spans) { | |||
|
|
|||
| private static List<Span> fromBase64(String base64) { | |||
| byte[] bytes = Base64.decode(base64); | |||
| return Codec.THRIFT.readSpans(bytes); | |||
| return SpanDecoder.DETECTING_DECODER.readSpans(bytes); | |||
There was a problem hiding this comment.
this works with all the formats and prevents us from needing to access internal classes (for the not yet released span2 type)
| @@ -68,6 +69,9 @@ public static Builder builder() { | |||
| /** Maximum size of a message. Kinesis max message size is 1MB */ | |||
| Builder messageMaxBytes(int messageMaxBytes); | |||
|
|
|||
| /** Allows you to change to json format. Default is thrift */ | |||
| Builder encoding(Encoding encoding); | |||
There was a problem hiding this comment.
note: "encoding" is thrift or json, the "encoder" says how to encode in thrift or json. So, this automatically works with any format, span1 or span2
codefromthecrypt
force-pushed
the
json-encoding
branch
from
15ea81e to
00686de
Compare
Before the AWS transports only supported thrift encoding. This adds json support, which will notably be used for zipkin2 format. This uses the recently released detecting decoder to support the new Span2 format defined in openzipkin/zipkin#1499
codefromthecrypt
force-pushed
the
json-encoding
branch
from
00686de to
47a077b
Compare
codefromthecrypt
changed the title
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the AWS transports only supported thrift encoding. This adds json
support, which will notably be used for zipkin2 format.
This uses the recently released detecting decoder to support the new
Span2 format defined in openzipkin/zipkin#1499