Skip to content

Commit

Permalink
Set Go support policy to latest-2 (#220)
Browse files Browse the repository at this point in the history
Before updating deps, we should revisit the go support policy I think.
That way the next release is coherent across the board. This is the same
templating as wazero, which had to deal with some projects that lagged
behind Go.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
  • Loading branch information
codefromthecrypt authored Apr 24, 2024
1 parent a074cdb commit 48cf793
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ jobs:
"CI":
runs-on: ${{ matrix.os }}
strategy:
matrix:
matrix: # Use versions consistent with zipkin-go's Go support policy.
os: [macos-latest, windows-latest, ubuntu-latest]
go: ["1.20"]
go: ["1.22"] # Current Go version
include:
- os: ubuntu-latest
go: "1.18"
go: "1.21"
- os: ubuntu-latest
go: "1.19"
go: "1.20" # Floor Go version of zipkin-go (current - 2)
steps:
# Set fetch-depth: 0 to fetch commit history and tags for use in version calculation
- name: Check out code
Expand Down
14 changes: 13 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,17 @@ Producer digesting JSON V2 Spans. The reporter uses the
[Sarama async producer](https://pkg.go.dev/github.com/IBM/sarama#AsyncProducer)
underneath.

## usage and examples
## Usage and Examples
[HTTP Server Example](examples/httpserver_test.go)

## Go Support Policy

zipkin-go follows the same version policy as Go's [Release Policy](https://go.dev/doc/devel/release):
two versions. zipkin-go will ensure these versions work and bugs are valid if
there's an issue with a current Go version.

Additionally, zipkin-go intentionally delays usage of language or standard
library features one additional version. For example, when Go 1.29 is released,
zipkin-go can use language features or standard libraries added in 1.27. This
is a convenience for embedders who have a slower version policy than Go.
However, only supported Go versions may be used to raise support issues.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/openzipkin/zipkin-go

go 1.18
go 1.20

require (
github.com/IBM/sarama v1.40.1
Expand Down

0 comments on commit 48cf793

Please sign in to comment.