Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to latest actions and fixes golangci-lint drift #221

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

codefromthecrypt
Copy link
Member

No description provided.

@codefromthecrypt codefromthecrypt marked this pull request as draft April 19, 2024 18:46
@codefromthecrypt
Copy link
Member Author

I'll unmark as draft when windows works with lint again..

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt codefromthecrypt changed the title Updates to latest golangci-lint-action and fixes mandatory checks Updates to latest actions and fixes golangci-lint drift Apr 19, 2024
Copy link
Member Author

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes!

@@ -10,8 +10,6 @@ on:

jobs:
"CI":
env:
GO111MODULE: on
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default for a while

@@ -1,6 +1,8 @@
run:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes here are config drift and golint removed for revive

@@ -31,7 +31,7 @@ var (
)

func httpHandler(code int, headers http.Header, body *bytes.Buffer) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
return func(w http.ResponseWriter, _ *http.Request) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything below here are new checks, but hopefully not a big deal

@codefromthecrypt codefromthecrypt marked this pull request as ready for review April 19, 2024 19:03
@codefromthecrypt codefromthecrypt merged commit a074cdb into master Apr 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants