brave: allows AsyncZipkinSpanHandler to be built with custom formats #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
commented
Jan 9, 2024
| * @since 3.1 | ||
| */ | ||
| // AsyncZipkinSpanHandler not SpanHandler, so that Flushable and Closeable are accessible | ||
| public AsyncZipkinSpanHandler build(BytesEncoder<MutableSpan> encoder) { |
There was a problem hiding this comment.
I noticed that we can't really move off zipkin types without this, as this handler only worked with json! Will release 3.1.0 shortly afterwards.
codefromthecrypt
changed the title
anuraaga
approved these changes
Jan 9, 2024
This is needed for stackdriver and any future OTLP work, as well as developing a standard proto encoder. Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
custom-format
branch
from
96ff702
to
dadb6cf
Compare
|
added tests and will merge on green. Thanks for the look @anuraaga! |
|
after this https://github.com/openzipkin-contrib/zipkin-otel can have a brave encoder and sender without dependencies on zipkin types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for stackdriver and any future OTLP work, as well as developing a standard proto encoder.