Adds HttpSender to aid proper handling of HttpEndpointSupplier #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <adrian@tetrate.io>
| import static zipkin2.TestObjects.CLIENT_SPAN; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class HttpSenderTest { |
There was a problem hiding this comment.
tests here were duplicated between urlconnection and okhttp senders. since the behavior is proven here, it is less work to port the resttemplate and webclient senders in boot, as I don't need to copy/paste these tests and burden folks to review them
|
have one more change on top of this that I thought of overnight, but unrelated, so will make another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that implementing constant and dynamic endpoint handing properly is a chore, especially to test it. This adds
HttpSenderas a second base type. It handles the edge cases so implementors don't have to.I also added
SenderAdapterwhich helps deal with the Call contract stuff until we can delete it. I also deleted some async tests from okhttp as we don't promise that sort of behavior on a deprecated and unused function. (For example, otel no longer use the async call stuff).