Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track JDK 13 support #2893

Closed
codefromthecrypt opened this issue Oct 29, 2019 · 1 comment · Fixed by #2966
Closed

track JDK 13 support #2893

codefromthecrypt opened this issue Oct 29, 2019 · 1 comment · Fixed by #2966

Comments

@codefromthecrypt
Copy link
Member

We need to retain JRE 1.6 compat, and we use retrolambda to do this. However, retrolambda hasn't had a release in a year and it is broken with java 13 (luontola/retrolambda#154)

Even if we didn't use retrolambda for zipkin's core lib it is a pain. Not about the src/main tree as nothing interesting relies on java 1.8 syntax. More that intellij is too stupid to understand the source difference between src/main and src/test. To date, less than 10 thumbs up https://youtrack.jetbrains.com/issue/IDEA-161060 and honestly I doubt it would change anything anyway as I have another issue with many many more +1s and it is not addressed either. This implies that if we kill retrolambda we also have to move the test source to 1.6 which is annoying because of the neglected intellij issue.
@codefromthecrypt
Copy link
Member Author

oh and error-prone is also holding us back google/error-prone#1106

@codefromthecrypt codefromthecrypt mentioned this issue Oct 29, 2019
Closed
codefromthecrypt pushed a commit that referenced this issue Jan 24, 2020
Switches build to JDK 13
06dd617 
Not concerned about errorprone as it isn't highly value adding anyway.
When/if they ever fix the 1.5 year old issue, we can update the profile.

Fixes #2893
@codefromthecrypt codefromthecrypt mentioned this issue Jan 24, 2020
Merged
codefromthecrypt pushed a commit that referenced this issue Jan 24, 2020
@adriancole
Switches build to JDK 13 (#2966)
67f6ad4 
Not concerned about errorprone as it isn't highly value adding anyway.
When/if they ever fix the 1.5 year old issue, we can update the profile.

Fixes #2893
uhafner added a commit to jenkinsci/analysis-model that referenced this issue Jan 5, 2023
@uhafner
Fix JDK 11 bug on Windows during JavaDoc creation.
15683d2 
See:
- https://issues.apache.org/jira/browse/MJAVADOC-586
- openzipkin/zipkin#2893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switches build to JDK 13 openzipkin/zipkin
1 participant
@codefromthecrypt