Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable additionalArgs and env variables for runtime container #220

Merged
merged 19 commits into from
Jun 11, 2024
Merged

Enable additionalArgs and env variables for runtime container #220

merged 19 commits into from
Jun 11, 2024

Conversation

mguthrie88
Copy link
Member

No description provided.

mike.guthrie and others added 13 commits June 7, 2024 13:58
Thread log settings into values file
24f3c11
@github-actions
helm-docs: automated action
d272772
@qrkourier
Merge pull request #218 from openziti/clarify-controller-readme
f0eb683 
clarify controller service input values with a checklist
Bumped "ziti-router" version from "1.0.4" to "1.0.5".
4889c85 
Changes committed by mguthrie88 in commit:  altered the Helm Chart.
I updated the "version" in Chart.yaml file using the "patch" strategy.

Signed-off-by: github-bot[bot] <bot@github.com>
@qrkourier
Merge branch 'main' into enable_log_config
c58adff
Make ziti binary overrides easier to pass in for any argument
a3ad8ec
Merge in latest changes from main
e19d949
Fix merge markers
0ee134a
Update charts to support additionalArgs and env variables as an arbit…
68d5375 
…rary list
@github-actions
helm-docs: automated action
c4cdf8d
Fix examples and doc
69ad58f
Merge branch 'enable_log_config' of github.com:openziti/helm-charts i…
6722654 
…nto enable_log_config
@github-actions
helm-docs: automated action
89ad4b7
qrkourier
qrkourier requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It's going to be so much easier to pass --verbose now.

charts/ziti-controller/values.yaml Outdated Show resolved Hide resolved
charts/ziti-controller/values.yaml Outdated Show resolved Hide resolved
charts/ziti-router/values.yaml Outdated Show resolved Hide resolved
qrkourier
qrkourier requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

charts/ziti-router/values.yaml Outdated Show resolved Hide resolved
charts/ziti-controller/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/ziti-controller/values.yaml Outdated Show resolved Hide resolved
qrkourier
qrkourier approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mguthrie88 mguthrie88 merged commit e13fcd2 into main Jun 11, 2024
1 check passed
@mguthrie88 mguthrie88 deleted the enable_log_config branch June 11, 2024 15:43
@qrkourier qrkourier mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qrkourier qrkourier qrkourier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mguthrie88 @qrkourier @marvkis