updates to doc for zdew/ext-jwt-signer #1002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
qrkourier
requested changes
Dec 20, 2024
| channels are not meant for direct use and using them outside of the overall tunneler is discouraged. | ||
|
|
||
| ### The Data Service | ||
| The data service is the main workhorse of the ZDEW. It is built around the `ziti-tunneler-sdk-c` (and subsequently the |
There was a problem hiding this comment.
ziti-tunneler-sdk-c doesn't mean much to many readers without a link or context. Maybe we should refer to it generically as the Ziti tunneler SDK or link to the repo if we want people to learn this comparatively obscure project name. Readers are more likely to be familiar with zitie-dge-tunnel, and the daylight between them is slim.
| @@ -0,0 +1,17 @@ | |||
| ## Configuring External Auth in OpenZiti | |||
There was a problem hiding this comment.
How about a link to next steps assuming they want to do this
| * jwks-endpoint - a URL used by the OpenZiti Controller to verify the provided JWT | ||
| * claims-property to match (often `email`). The JWT must contain a claim with the provided value | ||
| * scopes - additional scopes to request from the provider. Often `email` or `profile` | ||
| * external-auth-url - the URL users are directed to for authentication with the external provider |
There was a problem hiding this comment.
Suggested change
| * external-auth-url - the URL users are directed to for authentication with the external provider | |
| * external-auth-url - the URL users are directed to for authentication with the external provider | |
| [Learn more about external JWT signers](/learn/core-concepts/security/authentication/50-external-jwt-signers.md) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial PR for ZDEW doc around external jwt providers