Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate OIDC TOTP Redirect w/ application/json #2282

Closed
andrewpmartinez opened this issue Aug 1, 2024 · 0 comments · Fixed by #2284
Closed

Investigate OIDC TOTP Redirect w/ application/json #2282

andrewpmartinez opened this issue Aug 1, 2024 · 0 comments · Fixed by #2284

Comments

@andrewpmartinez
Copy link
Member

The OIDC flow for TOTP is when a browser or a client that accepts text/HTML will receive a redirect (login.go:237 checkTotp()), but an application/JSON accept time will receive a 200ok.

This should complete the flow and the GO SDK in authrwapper.go should respect that redirect.
@andrewpmartinez andrewpmartinez converted this from a draft issue Aug 1, 2024
@andrewpmartinez andrewpmartinez moved this from Todo to In Progress in Security/IdP Features & Capabilities Aug 1, 2024
andrewpmartinez added a commit to openziti/sdk-golang that referenced this issue Aug 1, 2024
@andrewpmartinez
related to openziti/ziti#2282 totp OIDC flow fixes
0a91679
andrewpmartinez added a commit to openziti/sdk-golang that referenced this issue Aug 1, 2024
@andrewpmartinez
Merge pull request #604 from openziti/fix.2282.oidc.totp.flow
02841ee 
related to openziti/ziti#2282 totp OIDC flow fixes
andrewpmartinez added a commit that referenced this issue Aug 1, 2024
@andrewpmartinez
fixes #2282 TOTP flow for OIDC was inconsistent
67e2660 
- redirect on HTML/JSON
- fixes missing issuer context
- adds a test for cert + totp
@ekoby ekoby linked a pull request Aug 5, 2024 that will close this issue
Fix.2282.fix.OIDC.totp.flow #2284
Merged
andrewpmartinez added a commit to openziti/sdk-golang that referenced this issue Aug 7, 2024
@andrewpmartinez
relates to openziti/ziti#2282 issues with default audience
fa6227c
@plorenz plorenz changed the title Investigate OIDC TOTP Redirect w/ applicaiton/json Investigate OIDC TOTP Redirect w/ application/json Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Security/IdP Features & Capabilities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix.2282.fix.OIDC.totp.flow openziti/ziti
1 participant
@andrewpmartinez