fixes #2478 legacy auth queries missing values #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovholuknf
approved these changes
Oct 11, 2024
ekoby
reviewed
Oct 11, 2024
| @@ -90,6 +90,9 @@ func MapApiSessionAuthQueriesToRestEntity(ae *env.AppEnv, rc *response.RequestCo | |||
| MinLength: authQuery.MinLength, | |||
| Provider: authQuery.Provider, | |||
| TypeID: authQuery.TypeID, | |||
There was a problem hiding this comment.
I don't see these fields populated in API session returned from /authenticate?method=cert call
There was a problem hiding this comment.
the same with HA controller: /oidc/login/cert returns
{"authQueries":[{"id":"2u9E63jXaAn7wAvG6vPKWa","provider":"url","scopes":null,"typeId":"EXT-JWT"}]}
There was a problem hiding this comment.
That would be odd for legacy, specifically in this PR, because there are tests in this PR that ensure that,
Can you confirm the correct ext-jwt-signer is being configured and used?
There was a problem hiding this comment.
I also added a set of OIDC value checks, and the values I put in seem to come out.
|
seems to at least partially resolve #2478 |
andrewpmartinez
changed the title
andrewpmartinez
force-pushed
the
fix.2478.legacy.auth.quers.ext.jwt.missing.values
branch
from
83812b4 to
17c4c93
Compare
- adds OIDC property checks on auth queries - adds legacy property checks on auth queries
andrewpmartinez
force-pushed
the
fix.2478.legacy.auth.quers.ext.jwt.missing.values
branch
from
17c4c93 to
5133cd7
Compare
andrewpmartinez
deleted the
fix.2478.legacy.auth.quers.ext.jwt.missing.values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.