fix quickstart dns sans #2485
Merged
fix quickstart dns sans #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrkourier
changed the title
qrkourier
commented
Oct 15, 2024
| pull_request: | ||
| paths: | ||
| - 'quickstart/**' | ||
| branches: |
There was a problem hiding this comment.
stop waiting for quickstart files to change so this runs earlier in the ziti life cycle
| @@ -1,5 +1,9 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -o errexit | |||
There was a problem hiding this comment.
raise uncaught exceptions
| @@ -32,6 +36,9 @@ if [[ "${_ZITI_ROUTER_NAME}" != "" ]]; then | |||
| fi | |||
|
|
|||
| _CONFIG_PATH="${ZITI_HOME}/${ZITI_ROUTER_NAME}.yaml" | |||
| # Set an error trap to move _CONFIG_PATH when it's unsafe to assume enrollment succeeded | |||
| trap '[[ -f "${_CONFIG_PATH}" ]] && mv "${_CONFIG_PATH}" "${_CONFIG_PATH}.err"' ERR | |||
There was a problem hiding this comment.
make the script more resilient against bad state problems resulting from an incomplete run
| @@ -55,8 +62,8 @@ if [ ! -f "${_CONFIG_PATH}" ]; then | |||
| createPrivateRouterConfig "${ZITI_ROUTER_NAME}" | |||
| fi | |||
|
|
|||
| found=$("${ZITI_BIN_DIR-}/ziti" edge list edge-routers 'name = "'"${ZITI_ROUTER_NAME}"'"' | grep -c "${ZITI_ROUTER_NAME}") | |||
| if [[ found -gt 0 ]]; then | |||
There was a problem hiding this comment.
[[ found -gt 0 ]] is always false
| @@ -784,17 +784,18 @@ function createPki { | |||
| _pki_create_intermediate "${ZITI_GRANDPARENT_INTERMEDIATE}" "${ZITI_PKI_SIGNER_INTERMEDIATE_NAME}" 1 | |||
|
|
|||
| echo " " | |||
| pki_allow_list="localhost,${ZITI_NETWORK}" | |||
| ctrl_pki_allow_list="localhost,${ZITI_NETWORK}" | |||
There was a problem hiding this comment.
keep ctrl and edge DNS SANs separate
dovholuknf
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.