Skip to content

Commit

Permalink
external html path configuration for interstitial (#716)
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelquigley committed Aug 6, 2024
1 parent 379f6b8 commit ba32e4c
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 11 deletions.
1 change: 1 addition & 0 deletions endpoints/publicProxy/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type Config struct {

type InterstitialConfig struct {
Enabled bool
HtmlPath string
UserAgentPrefixes []string
}

Expand Down
2 changes: 1 addition & 1 deletion endpoints/publicProxy/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func shareHandler(handler http.Handler, pcfg *Config, key []byte, ctx ziti.Conte
_, zrokOkErr := r.Cookie("zrok_interstitial")
if skip == "" && zrokOkErr != nil {
logrus.Debugf("forcing interstitial for '%v'", r.URL)
interstitialUi.WriteInterstitialAnnounce(w)
interstitialUi.WriteInterstitialAnnounce(w, pcfg.Interstitial.HtmlPath)
return
}
}
Expand Down
36 changes: 26 additions & 10 deletions endpoints/publicProxy/interstitialUi/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,35 @@ package interstitialUi
import (
"github.com/sirupsen/logrus"
"net/http"
"os"
)

func WriteInterstitialAnnounce(w http.ResponseWriter) {
if data, err := FS.ReadFile("index.html"); err == nil {
w.WriteHeader(http.StatusOK)
n, err := w.Write(data)
if n != len(data) {
logrus.Errorf("short write")
return
var externalFile []byte

func WriteInterstitialAnnounce(w http.ResponseWriter, htmlPath string) {
if htmlPath != "" && externalFile == nil {
if data, err := os.ReadFile(htmlPath); err == nil {
externalFile = data
} else {
logrus.Errorf("error reading external interstitial file '%v': %v", htmlPath, err)
}
if err != nil {
logrus.Error(err)
return
}
var htmlData = externalFile
if htmlData == nil {
if data, err := FS.ReadFile("index.html"); err == nil {
htmlData = data
} else {
logrus.Errorf("error reading embedded interstitial html 'index.html': %v", err)
}
}
w.WriteHeader(http.StatusOK)
n, err := w.Write(htmlData)
if n != len(htmlData) {
logrus.Errorf("short write")
return
}
if err != nil {
logrus.Error(err)
return
}
}

0 comments on commit ba32e4c

Please sign in to comment.