-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/automated releasing #5
Merged
everettraven
merged 10 commits into
operator-framework:main
from
everettraven:ci/automated-releasing
Aug 24, 2023
Merged
Ci/automated releasing #5
everettraven
merged 10 commits into
operator-framework:main
from
everettraven:ci/automated-releasing
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently e2e tests are expected to fail. We should probably get #4 merged prior to this PR so we can have passing e2e with new samples being properly generated. /hold |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
…bilities Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
68de779
to
20bcdc6
Compare
' Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
oceanc80
reviewed
Aug 23, 2023
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
/hold cancel |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
/lgtm |
oceanc80
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
.goreleaser.yml
file to use GoReleaser to automate the binary+image build/push process for a releaseansible-operator
binary build target so the image build works appropriately when using themake image-build
command to build the ansible-operator image locally.Motivation for the change:
Open Question:
ansible-operator-plugins/internal/version/version.go
Line 29 in ab43854
FROM
directive when scaffolding the Dockerfile. Any thoughts on how we can adapt this such that we don't have to manually update this as a pre-release step? Typically this would be set as part of building the binary but the current intention is that this is used as a library by Operator-SDK so it will be whatever the string literal is. I'm having trouble with coming up with a way to resolve this without having to have a manual pre-release step of updating this.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs