chore: bump k8s deps to 1.24 & makefile go 1.18 support #242
Conversation
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
changed the title
|
I did mention to Bryce we should be bumping 1.18 as k8s 1.24 is built using Go 1.18. |
|
/lgtm |
There was a problem hiding this comment.
I don't see any problems with this PR specifically. However, given registry and olm repos do vendor api, these two repos will need to do a k8s 1.24 bump as well. Registry is still in 1.22 while olm is on 1.23 already. Assuming they have no problems with 1.24 bump, then this PR should be good to go.
@joelanford FYI
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override Go/go-apidiff |
|
@njhale: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
As per @njhale /override go-apidiff |
|
@everettraven: everettraven unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dinhxuanvu Are you suggesting that OLM and Registry are updated to support k8s 1.24 before this PR is merged? |
No. This PR should go in first and then should be vendored into registry and olm soon and bump k8s at the same time. |
|
/override go-apidiff |
|
@dinhxuanvu: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of change
Motivation for the change
Kubernetes 1.24 has been released and is built with Go 1.18, so we need to update this library to support k8s 1.24 so the rest of the Operator Framework tools can begin making changes to support k8s 1.24. This also modifies the Makefile to allow for the support of Go 1.18 when it comes time to make the Go version bump