Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(catsrc) rename grpcPodConfig.runAsRoot to grpcPodConfig.SecurityContextConfig #261

Merged
merged 1 commit into from
Sep 13, 2022
Merged

(catsrc) rename grpcPodConfig.runAsRoot to grpcPodConfig.SecurityContextConfig #261

merged 1 commit into from
Sep 13, 2022

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Sep 8, 2022 •
edited

Accepted values for SecurityContextConfig(string): legacy/restricted(default)

@anik120 anik120 mentioned this pull request Sep 8, 2022
Merged
11 tasks
@anik120 anik120 force-pushed the intro-requirePrivilegedAccess branch from 55379b1 to 2a56ea0 Compare September 8, 2022 16:15
@anik120
Copy link
Contributor Author

anik120 commented Sep 8, 2022 •
edited

Like the previous PR, need to ignore the go-apidiff target for this one:

 Incompatible changes:
  - GrpcPodConfig.RunAsRoot: removed
  Compatible changes:
  - (*GrpcPodConfig).UnmarshalJSON: added
  - GrpcPodConfig.SecurityContextConfig: added
  - Legacy: added
  - Restricted: added
  - SecurityConfig: added

@anik120 anik120 force-pushed the intro-requirePrivilegedAccess branch 2 times, most recently from 4593c03 to a16870e Compare September 12, 2022 17:19
@anik120 anik120 changed the title (catsrc) rename grpcPodConfig.runAsRoot to grpcPodConfig.RequirePrivilegedAccess (catsrc) rename grpcPodConfig.runAsRoot to grpcPodConfig.SecurityContextConfig Sep 12, 2022
@anik120
Copy link
Contributor Author

anik120 commented Sep 12, 2022

/override go-apidiff

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2022

@anik120: Overrode contexts on behalf of anik120: go-apidiff

In response to this:

/override go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anik120 anik120 force-pushed the intro-requirePrivilegedAccess branch from a16870e to 2efdbf6 Compare September 12, 2022 17:47
@grokspawn
Copy link
Contributor

grokspawn commented Sep 12, 2022 •
edited

/lgtm

@grokspawn grokspawn added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@awgreene awgreene mentioned this pull request Sep 12, 2022
Merged
@anik120 anik120 force-pushed the intro-requirePrivilegedAccess branch from 2efdbf6 to 535a15d Compare September 12, 2022 22:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
awgreene
awgreene requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More or less ready to approve this. Great work @anik120!

pkg/operators/v1alpha1/catalogsource_types.go Outdated Show resolved Hide resolved
@anik120 anik120 force-pushed the intro-requirePrivilegedAccess branch from 535a15d to d68bde8 Compare September 13, 2022 13:45
@anik120
(catsrc) rename grpcPodConfig.runAsRoot to grpcPodConfig.SecurityCont…
eabcd48 
…extConfig

Accepted values for SecurityContextConfig(string): legacy/resctricted(default)
@anik120 anik120 force-pushed the intro-requirePrivilegedAccess branch from d68bde8 to eabcd48 Compare September 13, 2022 14:42
@awgreene
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@anik120
Copy link
Contributor Author

anik120 commented Sep 13, 2022

/override go-apidiff

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

@anik120: Overrode contexts on behalf of anik120: go-apidiff

In response to this:

/override go-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit dfe859e into operator-framework:master Sep 13, 2022
anik120 added a commit to anik120/operator-lifecycle-manager that referenced this pull request Sep 13, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (operator-framework…
108e1ae 
…#2848)"

This reverts commit bd97e32.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting operator-framework#2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
@anik120 anik120 mentioned this pull request Sep 13, 2022
Merged
11 tasks
openshift-merge-robot pushed a commit to operator-framework/operator-lifecycle-manager that referenced this pull request Sep 13, 2022
@anik120
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
bfeb1e4 
This reverts commit bd97e32.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Oct 24, 2022
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
0d36dce 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: perdasilva
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Oct 24, 2022
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
c524345 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: perdasilva
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2023
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
87e0265 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2023
@anik120 @perdasilva
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
cbf6a8f 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Mar 15, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
0b624b4 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Mar 28, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
e963abd 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 11, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
17d809e 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 17, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
cc5fcb3 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 20, 2023
@anik120 @tmshort
Revert "chore: update o-f/api dependency to v0.17 (#2848)" (#2858)
0e821b4 
This reverts commit bd97e32644f5a6c5a2b87668df5261a4da62a2a6.

An older v0.17.0 release of operator-framework/api had the spec.RunAsRoot
field, which has [now been updated to be the spec.GrpcPodConfig.SecurityContextConfig
field](operator-framework/api#261). Reverting #2848 so that
the new v0.17.0 can be pulled in. See [this comment](operator-framework/operator-lifecycle-manager#2848 (comment)) for more info.

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: bfeb1e46819bc840190f4d7d0720712683387973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@perdasilva perdasilva perdasilva left review comments

@awgreene awgreene awgreene requested changes

@dinhxuanvu dinhxuanvu dinhxuanvu requested changes

Assignees

@perdasilva perdasilva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@anik120 @grokspawn @awgreene @perdasilva @joelanford @dinhxuanvu @openshift-merge-robot