Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17157: CatalogSource: add configurations for gRPC server memory footprint #288

Conversation

stevekuznetsov
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #288 (8a5559b) into master (92e4341) will increase coverage by 0.17%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 8a5559b differs from pull request most recent head 5842818. Consider uploading reports for the commit 5842818 to get more accurate results

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   41.94%   42.11%   +0.17%     
==========================================
  Files          39       39              
  Lines        3488     3495       +7     
==========================================
+ Hits         1463     1472       +9     
+ Misses       1879     1877       -2     
  Partials      146      146              
Files Changed Coverage Δ
crds/zz_defs.go 35.84% <ø> (ø)
pkg/operators/v1alpha1/catalogsource_types.go 57.69% <ø> (ø)
pkg/operators/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@stevekuznetsov stevekuznetsov force-pushed the skuznets/configure-catalog-source-memory branch from dd07898 to 88319a7 Compare August 1, 2023 14:14
@stevekuznetsov stevekuznetsov changed the title CatalogSource: add configurations for gRPC server memory footprint OCPBUGS-17157: CatalogSource: add configurations for gRPC server memory footprint Aug 1, 2023
@stevekuznetsov stevekuznetsov force-pushed the skuznets/configure-catalog-source-memory branch 3 times, most recently from f8e0a45 to 858d290 Compare August 1, 2023 15:23
@joelanford
Copy link
Member

/approve

Looks like something to fix up in bindata though?

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@stevekuznetsov stevekuznetsov force-pushed the skuznets/configure-catalog-source-memory branch from 8a5559b to 1dbe90e Compare August 3, 2023 14:37
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/configure-catalog-source-memory branch from 1dbe90e to 5842818 Compare August 3, 2023 14:42
@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@stevekuznetsov
Copy link
Member Author

Bindata got fixed, going to self-tag and ask for forgiveness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants