Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github.com/ghodss/yaml with sigs.k8s.io/yaml #308

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

Juneezee
Copy link
Contributor

The github.com/ghodss/yaml package is no longer actively maintained. There are numerous inquiries about the project's status on its issue tracker: https://github.com/ghodss/yaml/issues. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml, which is actively maintained.

sigs.k8s.io/yaml was already an indirect dependency before this pull request was made, and github.com/ghodss/yaml is only used in tests files. We can safely replace it and remove 1 extra dependency.

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
Copy link

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, Juneezee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 5efe1a2 into operator-framework:master Nov 17, 2023
4 checks passed
stevekuznetsov pushed a commit to operator-framework/operator-registry that referenced this pull request Dec 4, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 5, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 7, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 8, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 12, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 15, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 18, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 19, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 19, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 20, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/operator-framework-olm that referenced this pull request Dec 21, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/operator-framework-olm that referenced this pull request Dec 21, 2023
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 6df3abad48bb338b51986cc89877d89fc1b3e39d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants