Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing comments for status fields #316

Merged

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Feb 26, 2024

solves #317

Copy link

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.45%. Comparing base (d4f3de3) to head (8ef2b3d).

❗ Current head 8ef2b3d differs from pull request most recent head c180dcf. Consider uploading reports for the commit c180dcf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   42.45%   42.45%           
=======================================
  Files          42       42           
  Lines        4011     4011           
=======================================
  Hits         1703     1703           
  Misses       2156     2156           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn force-pushed the catalogsource-status branch 2 times, most recently from 3f8d243 to 8ef2b3d Compare February 26, 2024 20:55
GRPCConnectionState *GRPCConnectionState `json:"connectionState,omitempty"`
// ConfigMapReference (deprecated) is the reference to the ConfigMap containing the catalog source's configuration, when the catalog source is a ConfigMap
ConfigMapResource *ConfigMapResourceReference `json:"configMapReference,omitempty"`
// RegistryService is the GRPC service that the catalog source is using to serve the catalog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't actually describe the meaning of this field, it just describes what the field is describing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, phooey. Thought I'd fixed that chatgpt'd fluff before I opened it. Updated now.

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bdb0455 into operator-framework:master Feb 26, 2024
4 checks passed
@grokspawn grokspawn deleted the catalogsource-status branch February 26, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants