🌱 Add GHA to test CRDs against kind #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
perdasilva/apply-test
branch
4 times, most recently
from
5767042
to
620cce4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 39.43% 39.43%
=======================================
Files 56 56
Lines 4516 4516
=======================================
Hits 1781 1781
Misses 2581 2581
Partials 154 154 ☔ View full report in Codecov by Sentry. |
perdasilva
force-pushed
the
perdasilva/apply-test
branch
5 times, most recently
from
ef27bf0
to
f7e4276
Compare
… client-go Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
perdasilva/apply-test
branch
from
f7e4276
to
0fb0760
Compare
m1kola
approved these changes
May 22, 2024
Comment on lines
+127
to
+130
| .PHONY: kind | ||
| kind: $(KIND) ## Download yq locally if necessary. | ||
| $(KIND): $(LOCALBIN) | ||
| GOBIN=$(LOCALBIN) go install $(GO_INSTALL_OPTS) sigs.k8s.io/kind@latest |
There was a problem hiding this comment.
Nit: Might be worth adding bingo into this repo.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m1kola, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the api repo is green but the CRDs cannot be applied. This PR adds a job to the repo to check that the generated CRDs can be applied to a kind cluster running on the same kube version as the client-go in go.mod