Skip to content

Commit

Permalink
update images and add some TODO comments
Browse files Browse the repository at this point in the history
based on conversations had in review comments

Signed-off-by: Bryce Palmer <everettraven@gmail.com>
  • Loading branch information
everettraven committed Jan 31, 2023
1 parent cc3d9e0 commit 3d46a02
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
2 changes: 1 addition & 1 deletion config/aggregated-apiserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ spec:
spec:
containers:
- name: apiserver
image: docker.io/bpalmer/rukpak-packageserver:latest
image: docker.io/anik120/rukpak-packageserver:latest
imagePullPolicy: IfNotPresent
volumeMounts:
- name: apiserver-certs
Expand Down
6 changes: 3 additions & 3 deletions config/controller-manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ spec:
runAsUser: 0
containers:
- name: controller
image: docker.io/bpalmer/catalogsource-controller:latest
image: docker.io/anik120/catalogsource-controller:latest
imagePullPolicy: IfNotPresent
command:
- "./manager"
args: []
resources:
requests:
cpu: 100m
cpu: 1000m
memory: 200Mi
limits:
cpu: 100m
cpu: 1000m
memory: 300Mi
volumes:
- name: apiserver-certs
Expand Down
8 changes: 8 additions & 0 deletions pkg/apis/core/v1beta1/bundlemetadata_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,19 @@ type BundleMetadataSpec struct {
RelatedImages []RelatedImage `json:"relatedImages"`
}

// TODO: In the future we should remove this in favor of using `property.Property` from
// https://pkg.go.dev/github.com/operator-framework/operator-registry@v1.26.3/alpha/property#Property
// This will likely require some changes to the `property.Property` type to
// make it suitable for usage within the Spec for a CustomResource
type Property struct {
Type string `json:"type"`
Value []byte `json:"value"`
}

// TODO: In the future we should remove this in favor of using `model.RelatedImage` (or similar) from
// https://pkg.go.dev/github.com/operator-framework/operator-registry@v1.26.3/alpha/model#RelatedImage
// This will likely require some changes to the `model.RelatedImage` type
// to make it suitable for usage within the Spec for a CustomResource
type RelatedImage struct {
Name string `json:"name"`
Image string `json:"image"`
Expand Down

0 comments on commit 3d46a02

Please sign in to comment.