Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package resource naming clash if same named Package exists in multiple CatalogSources #12

Closed
everettraven opened this issue Mar 27, 2023 · 1 comment · Fixed by #76
Closed

Comments

@everettraven
Copy link
Collaborator

Currently the CatalogSource controller creates Package resources when reconciling a CatalogSource CR. It doesn't do any special naming logic to ensure uniqueness of Package resources being created which means that if multiple catalogs define a package of the same name (but are technically different), there will be a naming clash resulting in an error creating the corresponding Package resource.

We should evaluate what our options are to prevent this naming clash.

One suggestion is to see what options we have to specify the Package admission criteria on our custom apiserver. For more context see: #1 (comment)

@anik120
Copy link
Collaborator

anik120 commented Apr 13, 2023

This is probably not going to be an issue if we configure labels as discussed in #38. Multiple catalogs can include packages with the same name, but clients would have to distinguish between those packages by specifying the catalog they want the package from.

I.e kubectl get catalogmetadata -l package=foo,catalog=bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants